Page MenuHomeFreeBSD
Differential D56343

tunefs: Fix pointer arithmetic
ClosedPublic
Actions

Authored by des on Fri, Apr 10, 3:15 PM.
Tags
None
Referenced Files
F152554964: D56343.diff
Wed, Apr 15, 4:04 PM
Unknown Object (File)
Tue, Apr 14, 12:13 PM
Unknown Object (File)
Sat, Apr 11, 8:51 PM
Unknown Object (File)
Sat, Apr 11, 3:16 PM
Subscribers
imp
olce

Details

Reviewers
ivy
kevans
mckusick
Commits
rG9d95d806691e: tunefs: Fix pointer arithmetic
Summary

While here, remove a bogus const which has been there for years.

MFC after: 1 week
Reported by: ivy@
Fixes: 1b83e8a3f840 ("Constify string pointers.")
Fixes: 8244dd326265 ("tunefs: Better fix for arm64 alignment issues")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72111
Build 68994: arc lint + arc unit

Event Timeline

des created this revision.Fri, Apr 10, 3:15 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 10, 3:15 PM
des requested review of this revision.Fri, Apr 10, 3:15 PM
Harbormaster completed remote builds in B72110: Diff 175234.Fri, Apr 10, 3:15 PM
des updated this revision to Diff 175235.Fri, Apr 10, 3:28 PM

->

Harbormaster completed remote builds in B72111: Diff 175235.Fri, Apr 10, 3:28 PM
olce added a subscriber: olce.Fri, Apr 10, 3:50 PM
olce added inline comments.
sbin/tunefs/tunefs.c
717

Could you please remove as well the (uintptr_t) conversion that I suspect was here just to circumvent the bogus const in the signature?

des marked an inline comment as done.Fri, Apr 10, 3:52 PM
des added inline comments.
sbin/tunefs/tunefs.c
717

No, it was added last week to suppress an alignment warning and is still needed.

des mentioned this in D56245: tunefs: Better fix for arm64 alignment issues.Fri, Apr 10, 3:56 PM
des marked an inline comment as done.Fri, Apr 10, 4:06 PM
kevans accepted this revision.Sat, Apr 11, 4:41 PM

Whoops-

This revision is now accepted and ready to land.Sat, Apr 11, 4:41 PM
Closed by commit rG9d95d806691e: tunefs: Fix pointer arithmetic (authored by des). · Explain WhySat, Apr 11, 7:23 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG9d95d806691e: tunefs: Fix pointer arithmetic.
des mentioned this in rG84e7cd491fdf: tunefs: Better fix for arm64 alignment issues.Mon, Apr 13, 5:39 PM
des mentioned this in rGc4266d84c56f: tunefs: Better fix for arm64 alignment issues.

Revision Contents
Changeset List

PathSize
sbin/
tunefs/
4 lines

Diff 175235

View Options

sbin/tunefs/tunefs.c

Loading...