Page MenuHomeFreeBSD
Differential D56137

bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw
ClosedPublic
Actions

Authored by chris.longros_gmail.com on Sat, Mar 28, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 2, 11:27 PM
Unknown Object (File)
Mon, Mar 30, 7:38 PM
Unknown Object (File)
Mon, Mar 30, 1:17 PM
Subscribers
donner
glebius
imp
melifaro

Details

Reviewers
wulf
Commits
rGf3fc362c0fb2: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw
Summary

Generic Realtek vendor rules already match all 0x0bda Bluetooth devices. Remove the redundant per-product entries from ng_ubt_rtl.c, rtlbtfw main.c, and rtlbtfw.conf.

Test Plan

Built and tested the ng_ubt module on FreeBSD 16.0-CURRENT (amd64). Compiles cleanly with -Werror, module loads without issues.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71786
Build 68669: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Sat, Mar 28, 9:48 PM
Herald added subscribers: glebius, melifaro, donner, imp. · View Herald TranscriptSat, Mar 28, 9:48 PM
Harbormaster completed remote builds in B71786: Diff 174462.Sat, Mar 28, 9:48 PM
chris.longros_gmail.com requested review of this revision.Sat, Mar 28, 9:48 PM
chris.longros_gmail.com edited the test plan for this revision. (Show Details)Sat, Mar 28, 9:51 PM
chris.longros_gmail.com added a reviewer: wulf.
wulf added a comment.Sat, Mar 28, 10:03 PM

It seems that more files should be fixed. See your previous patch: https://reviews.freebsd.org/D56126

chris.longros_gmail.com updated this revision to Diff 174479.Sun, Mar 29, 3:08 PM
chris.longros_gmail.com retitled this revision from ng_ubt_rtl: remove redundant Realtek vendor device entries to bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw.
chris.longros_gmail.com edited the summary of this revision. (Show Details)
wulf accepted this revision.Sun, Mar 29, 5:18 PM
This revision is now accepted and ready to land.Sun, Mar 29, 5:18 PM
Closed by commit rGf3fc362c0fb2: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw (authored by chris.longros_gmail.com, committed by wulf). · Explain WhySun, Mar 29, 7:02 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rGf3fc362c0fb2: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw.

Revision Contents
Changeset List

PathSize
sys/
netgraph/
bluetooth/
drivers/
ubt/
24 lines

Diff 174462

View Options

sys/netgraph/bluetooth/drivers/ubt/ng_ubt_rtl.c

Loading...