diff3: set O_CLOEXEC on pipes
ClosedPublic
Actions

Authored by bapt on Sat, Mar 28, 8:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 13, 8:35 PM

	Unknown Object (File)
	Thu, Apr 9, 10:07 AM

	Unknown Object (File)
	Thu, Apr 9, 8:48 AM

	Unknown Object (File)
	Tue, Apr 7, 1:30 AM

	Unknown Object (File)
	Fri, Apr 3, 10:24 AM

	Unknown Object (File)
	Thu, Apr 2, 4:03 PM

	Unknown Object (File)
	Tue, Mar 31, 4:01 PM

	Unknown Object (File)
	Mon, Mar 30, 7:46 PM

View All 9 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG8fade076dd25: diff3: set O_CLOEXEC on pipes
rG945e60e018c2: diff3: set O_CLOEXEC on pipes

Summary

This avoid leaking pipe fd in children and simplifies the code

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71761
Build 68644: arc lint + arc unit

Event Timeline

bapt created this revision.Sat, Mar 28, 8:42 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 28, 8:42 AM

bapt requested review of this revision.Sat, Mar 28, 8:42 AM

Harbormaster completed remote builds in B71761: Diff 174424.Sat, Mar 28, 8:42 AM

bapt added a reviewer: kib.Sat, Mar 28, 8:43 AM

kib accepted this revision.Sat, Mar 28, 8:48 AM

This revision is now accepted and ready to land.Sat, Mar 28, 8:48 AM

Closed by commit rG945e60e018c2: diff3: set O_CLOEXEC on pipes (authored by bapt). · Explain WhySat, Mar 28, 8:56 AM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG945e60e018c2: diff3: set O_CLOEXEC on pipes.

bapt added a commit: rG8fade076dd25: diff3: set O_CLOEXEC on pipes.Mon, Apr 6, 4:52 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff3/

diff3.c

8 lines

Diff 174424

View Options

diff3: set O_CLOEXEC on pipesClosedPublicActions