diff3: set O_CLOEXEC on pipes
ClosedPublic
Actions

Authored by bapt on Mar 28 2026, 8:42 AM.

Tags

None

Referenced Files

	F166548519: D56120.id.diff
	Fri, Aug 14, 7:53 AM

	F166415036: D56120.id174424.diff
	Thu, Aug 13, 12:14 PM

	Unknown Object (File)
	Wed, Aug 12, 6:41 PM

	Unknown Object (File)
	Wed, Aug 12, 4:59 PM

	Unknown Object (File)
	Wed, Aug 12, 1:39 AM

	Unknown Object (File)
	Sun, Aug 9, 5:27 PM

	Unknown Object (File)
	Sun, Aug 9, 2:41 PM

	Unknown Object (File)
	Fri, Aug 7, 8:51 PM

View All 54 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG8fade076dd25: diff3: set O_CLOEXEC on pipes
rG945e60e018c2: diff3: set O_CLOEXEC on pipes

Summary

This avoid leaking pipe fd in children and simplifies the code

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Mar 28 2026, 8:42 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2026, 8:42 AM

bapt requested review of this revision.Mar 28 2026, 8:42 AM

Harbormaster completed remote builds in B71761: Diff 174424.Mar 28 2026, 8:42 AM

bapt added a reviewer: kib.Mar 28 2026, 8:43 AM

kib accepted this revision.Mar 28 2026, 8:48 AM

This revision is now accepted and ready to land.Mar 28 2026, 8:48 AM

Closed by commit rG945e60e018c2: diff3: set O_CLOEXEC on pipes (authored by bapt). · Explain WhyMar 28 2026, 8:56 AM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG945e60e018c2: diff3: set O_CLOEXEC on pipes.

bapt added a commit: rG8fade076dd25: diff3: set O_CLOEXEC on pipes.Apr 6 2026, 4:52 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff3/

diff3.c

8 lines

Diff 174427

View Options

diff3: set O_CLOEXEC on pipesClosedPublicActions