Page MenuHomeFreeBSD

mfi(4)/mrsas(4): Set sysctl name for driver versions consistently
ClosedPublic

Authored by michaelo on Mar 27 2026, 5:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 9:21 AM
Unknown Object (File)
Sun, May 24, 7:26 PM
Unknown Object (File)
Sat, May 23, 1:39 AM
Unknown Object (File)
Fri, May 22, 6:35 PM
Unknown Object (File)
Thu, May 14, 6:49 AM
Unknown Object (File)
Thu, May 14, 3:52 AM
Unknown Object (File)
Thu, May 14, 3:52 AM
Unknown Object (File)
Thu, May 14, 12:01 AM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71743
Build 68626: arc lint + arc unit

Event Timeline

michaelo created this revision.

it seems more common through the tree to just use "version" here, e.g kern.version or hw.nvidia.version.

it seems more common through the tree to just use "version" here, e.g kern.version or hw.nvidia.version.

That's a good point. What to do with the already existing name for mrsas? Add a new one and deprecate the old one in < 16?

I checked other Broadcom/AVAGO/LSI drivers (mpr, mpt). They all use "driver_version". So I think they should be either consistently "driver_version" or "version".

Good point. We should probably keep it consistent with those. I think aligning all of them to be more similar should probably be considered over the mailing list and in a different revision, if we decide to go down that route. Should we RELNOTES: yes or discuss this with others?

Good point. We should probably keep it consistent with those. I think aligning all of them to be more similar should probably be considered over the mailing list and in a different revision, if we decide to go down that route. Should we RELNOTES: yes or discuss this with others?

I'd at least move it to a separate revision and keep it out of scope of this review. I'd raise a new review next week for all Broadcom/AVAGO/LSI drivers.

@ziaee, given the conditions: Is this one good as it is?

Guys, I'd like to complete this. Can someone review and consent?

This is good with me, @avg ?

This revision is now accepted and ready to land.Thu, Apr 30, 5:06 PM