mfi(4)/mrsas(4): Set sysctl name for driver versions consistently

[michaelo]

Summary

Instead of printing the driver version over and over again if multiple
controllers are used, set a sysctl name for the used driver version.

MFC after: 3 days

[michaelo]

Tried live in action.

[michaelo]

Any comments?

[ziaee]

it seems more common through the tree to just use "version" here, e.g kern.version or hw.nvidia.version.

[michaelo]

In D56110#1287717, @ziaee wrote:

it seems more common through the tree to just use "version" here, e.g kern.version or hw.nvidia.version.

That's a good point. What to do with the already existing name for mrsas? Add a new one and deprecate the old one in < 16?

[michaelo]

I checked other Broadcom/AVAGO/LSI drivers (mpr, mpt). They all use "driver_version". So I think they should be either consistently "driver_version" or "version".

[ziaee]

Good point. We should probably keep it consistent with those. I think aligning all of them to be more similar should probably be considered over the mailing list and in a different revision, if we decide to go down that route. Should we RELNOTES: yes or discuss this with others?

[michaelo]

In D56110#1287730, @ziaee wrote:

Good point. We should probably keep it consistent with those. I think aligning all of them to be more similar should probably be considered over the mailing list and in a different revision, if we decide to go down that route. Should we RELNOTES: yes or discuss this with others?

I'd at least move it to a separate revision and keep it out of scope of this review. I'd raise a new review next week for all Broadcom/AVAGO/LSI drivers.

[michaelo]

@ziaee, given the conditions: Is this one good as it is?

[michaelo]

Guys, I'd like to complete this. Can someone review and consent?

[ziaee]

This is good with me, @avg ?