sys/arm/linux/imgact_linux.c
74–76	It's present on i386 implementation. I don't think it's really used (even in full Linux world). We can drop it if necessary. Plus, there is no specific adaptation for ARM.

Much of this seems to be copied from the i386 support, is it needed on arm? e.g. places it calls i386 specific functions.

sys/arm/linux/imgact_linux.c
74–76	I think we should remove it. The amd64 doesn't seem to have it.

In D6765#146642, @andrew wrote:

Much of this seems to be copied from the i386 support, is it needed on arm? e.g. places it calls i386 specific functions.

I was talking about linux_machdep.c.

In D6765#146644, @andrew wrote:

In D6765#146642, @andrew wrote:

Much of this seems to be copied from the i386 support, is it needed on arm? e.g. places it calls i386 specific functions.

I was talking about linux_machdep.c.

This patch is a simple copy of i386 implementation. Modifications made to machdep.c are done in patches 14 (https://reviews.freebsd.org/D6771) and 15 (https://reviews.freebsd.org/D6772).

In D6765#146725, @soutade_gmail.com wrote:

This patch is a simple copy of i386 implementation. Modifications made to machdep.c are done in patches 14 (https://reviews.freebsd.org/D6771) and 15 (https://reviews.freebsd.org/D6772).

Those patches should be merged with this. It makes it difficult to review something like this that should be considered a complete unit of work if it's split over multiple changes.

In D6765#146757, @andrew wrote:

In D6765#146725, @soutade_gmail.com wrote:

This patch is a simple copy of i386 implementation. Modifications made to machdep.c are done in patches 14 (https://reviews.freebsd.org/D6771) and 15 (https://reviews.freebsd.org/D6772).

Those patches should be merged with this. It makes it difficult to review something like this that should be considered a complete unit of work if it's split over multiple changes.