Page MenuHomeFreeBSD

Linux ARM 8/16
AbandonedPublic

Authored by soutade_gmail.com on Jun 8 2016, 2:50 PM.

Details

Reviewers
None
Summary

Linux ARM : copy linux.h, imgact_linux.c, linux_sysvec.c, linux_dummy.c, linux_machdep.c and linux_ipc64.h from sys/i386/linux (replace i386 by arm)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

soutade_gmail.com retitled this revision from to Linux ARM 8/16.
soutade_gmail.com updated this object.
soutade_gmail.com edited the test plan for this revision. (Show Details)
soutade_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
sys/arm/linux/imgact_linux.c
74–76

Do we care about a.out support? Does Linux ARM support it?

sys/arm/linux/imgact_linux.c
74–76

It's present on i386 implementation. I don't think it's really used (even in full Linux world). We can drop it if necessary. Plus, there is no specific adaptation for ARM.

Much of this seems to be copied from the i386 support, is it needed on arm? e.g. places it calls i386 specific functions.

sys/arm/linux/imgact_linux.c
74–76

I think we should remove it. The amd64 doesn't seem to have it.

Much of this seems to be copied from the i386 support, is it needed on arm? e.g. places it calls i386 specific functions.

I was talking about linux_machdep.c.

Much of this seems to be copied from the i386 support, is it needed on arm? e.g. places it calls i386 specific functions.

I was talking about linux_machdep.c.

This patch is a simple copy of i386 implementation. Modifications made to machdep.c are done in patches 14 (https://reviews.freebsd.org/D6771) and 15 (https://reviews.freebsd.org/D6772).

This patch is a simple copy of i386 implementation. Modifications made to machdep.c are done in patches 14 (https://reviews.freebsd.org/D6771) and 15 (https://reviews.freebsd.org/D6772).

Those patches should be merged with this. It makes it difficult to review something like this that should be considered a complete unit of work if it's split over multiple changes.

This patch is a simple copy of i386 implementation. Modifications made to machdep.c are done in patches 14 (https://reviews.freebsd.org/D6771) and 15 (https://reviews.freebsd.org/D6772).

Those patches should be merged with this. It makes it difficult to review something like this that should be considered a complete unit of work if it's split over multiple changes.

I'll make a v2 when patches 5 and 6 are OK