Differential D55995

rge.4: fix incorrect speed range in HARDWARE section
ClosedPublic
Actions

Authored by chris.longros_gmail.com on Fri, Mar 20, 5:48 PM.

Details

Reviewers

adrian

Group Reviewers

manpages

Commits

rG8f36a012d65f: rge.4: fix incorrect speed range in HARDWARE section

Summary

The HARDWARE section stated "PCIe 1GB to 1GB Ethernet devices"
which is incorrect. The RTL8125/8126/8127 chips support speeds
from 1Gbps to 10Gbps. Correct the range.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

rge.4: note that the driver manages PHY directly

The rge(4) driver does not use the miibus(4) interface for PHY
management. Instead, it accesses PHY registers directly via the
chip's OCP (On-Chip Peripheral) bus. Document this in the
DESCRIPTION section.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71593
Build 68476: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Fri, Mar 20, 5:48 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Mar 20, 5:48 PM

chris.longros_gmail.com requested review of this revision.Fri, Mar 20, 5:48 PM

Harbormaster completed remote builds in B71593: Diff 174028.Fri, Mar 20, 5:48 PM

chris.longros_gmail.com added a reviewer: adrian.Fri, Mar 20, 5:50 PM

rge.4: note that the driver manages PHY directly

Harbormaster completed remote builds in B71617: Diff 174071.Sat, Mar 21, 7:20 AM

chris.longros_gmail.com retitled this revision from rge.4: fix incorrect speed range in HARDWARE section to rge.4: fix speed range and document direct PHY management.Sat, Mar 21, 7:23 AM

chris.longros_gmail.com edited the summary of this revision. (Show Details)

ziaee added inline comments.Sat, Mar 21, 7:37 PM

share/man/man4/rge.4
122–125	For consistency with other drivers in the Hardware Release Notes, conforming to what I wrote in style.mdoc(5). We may want to explicitly mention 2.5Gb support so people can search for that, because it's very desirable for SOHO but not everything supports it.