Differential D55974

LinuxKPI: add supporting #includes
ClosedPublic
Actions

Authored by bz on Mar 19 2026, 8:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 18, 1:08 PM

	Unknown Object (File)
	Wed, Apr 15, 2:13 AM

	Unknown Object (File)
	Tue, Apr 14, 1:35 PM

	Unknown Object (File)
	Tue, Apr 14, 12:41 AM

	Unknown Object (File)
	Sun, Apr 12, 2:04 AM

	Unknown Object (File)
	Sat, Apr 11, 1:23 PM

	Unknown Object (File)
	Sun, Apr 5, 5:32 AM

	Unknown Object (File)
	Sat, Apr 4, 9:09 AM

View All 19 Files

Subscribers

Details

Reviewers

jhibbits
emaste

Group Reviewers

Commits

rG7d069d784651: LinuxKPI: add supporting #includes
rG29dce45d8c50: LinuxKPI: add supporting #includes
rG1d18872c2519: LinuxKPI: add supporting #includes

Summary

Compiling drm-kmod on !X86 does not include asm/smp.h which includes
preempt.h on FreeBSD. In order to compile drm-kmod on other
architectures add the secondary #includes for preempt.h to
spinlock.h and hardirq.h (which now also gets included from highmem.h)
to connect the #include chain.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
PR: 279864

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71559
Build 68442: arc lint + arc unit

Event Timeline

bz created this revision.Mar 19 2026, 8:32 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMar 19 2026, 8:33 PM

bz requested review of this revision.Mar 19 2026, 8:33 PM

Harbormaster completed remote builds in B71559: Diff 173959.Mar 19 2026, 8:33 PM

jhibbits accepted this revision.Mar 19 2026, 8:37 PM

This revision is now accepted and ready to land.Mar 19 2026, 8:37 PM

emaste accepted this revision.Mar 19 2026, 9:05 PM

Closed by commit rG1d18872c2519: LinuxKPI: add supporting #includes (authored by bz). · Explain WhyMar 21 2026, 9:17 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG1d18872c2519: LinuxKPI: add supporting #includes.

bz added a commit: rG29dce45d8c50: LinuxKPI: add supporting #includes.Tue, Mar 31, 8:28 PM

bz added a commit: rG7d069d784651: LinuxKPI: add supporting #includes.Wed, Apr 1, 4:34 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

1 line

1 line

1 line

Diff 173959

sys/compat/linuxkpi/common/include/linux/hardirq.h

Loading...

sys/compat/linuxkpi/common/include/linux/highmem.h

Loading...

sys/compat/linuxkpi/common/include/linux/spinlock.h

Loading...