Page MenuHomeFreeBSD
Differential D55824

kern_time: Honor the precise option when counting diff
ClosedPublic
Actions

Authored by aokblast on Thu, Mar 12, 9:23 AM.
Tags
None
Referenced Files
F151255635: D55824.id173602.diff
Tue, Apr 7, 3:47 AM
Unknown Object (File)
Sun, Apr 5, 2:06 PM
Unknown Object (File)
Sun, Apr 5, 1:18 PM
Unknown Object (File)
Wed, Apr 1, 11:53 AM
Unknown Object (File)
Sun, Mar 29, 11:56 PM
Unknown Object (File)
Sat, Mar 28, 12:18 PM
Unknown Object (File)
Wed, Mar 25, 9:29 AM
Unknown Object (File)
Wed, Mar 25, 6:27 AM
View All 18 Files
Subscribers
imp
olce

Details

Reviewers
kib
markj
imp
lwhsu
Commits
rG728ae49a6b81: kern_time: Honor the precise option when counting diff
Summary

When preecise option is used, the true elapsed time should also use the
precise timer.

This fixes the test case sleep_for.signals.pass.cpp in libcxx.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71360
Build 68243: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Mar 12, 9:23 AM
Herald added subscribers: olce, imp. · View Herald TranscriptThu, Mar 12, 9:23 AM
aokblast requested review of this revision.Thu, Mar 12, 9:23 AM
Harbormaster completed remote builds in B71359: Diff 173601.Thu, Mar 12, 9:23 AM
aokblast added reviewers: kib, markj.EditedThu, Mar 12, 9:24 AM

https://github.com/llvm/llvm-project/blob/788b2bde7b31615fd22c906b1acf2ba2072acf6b/libcxx/test/std/thread/thread.threads/thread.thread.this/sleep_for.signals.pass.cpp

The test is in here, which failed originally since the diff time is not >= 500ms.

aokblast updated this revision to Diff 173602.Thu, Mar 12, 9:25 AM

Formatting

Harbormaster completed remote builds in B71360: Diff 173602.Thu, Mar 12, 9:26 AM
aokblast added a reviewer: imp.Thu, Mar 12, 1:58 PM
kib accepted this revision.Thu, Mar 12, 2:08 PM
This revision is now accepted and ready to land.Thu, Mar 12, 2:08 PM
aokblast added a reviewer: lwhsu.Fri, Mar 13, 10:31 AM
lwhsu accepted this revision.Fri, Mar 13, 3:38 PM
imp accepted this revision.Fri, Mar 13, 4:21 PM

I read through everything two different times, and convinced myself both times this is the proper change.

Closed by commit rG728ae49a6b81: kern_time: Honor the precise option when counting diff (authored by aokblast). · Explain WhySat, Mar 14, 4:31 AM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: rG728ae49a6b81: kern_time: Honor the precise option when counting diff.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 173602

View Options

sys/kern/kern_time.c

Loading...