Paths

Table of Contentst

Differential D55671

virtual_oss: Combine -d, -l and -L option getopt code
ClosedPublic
Actions

Authored by christos on Thu, Mar 5, 3:58 PM.

Tags

None

Referenced Files

	F147494856: D55671.id173202.diff
	Wed, Mar 11, 10:27 AM

	F147493584: D55671.id.diff
	Wed, Mar 11, 10:16 AM

	F147483072: D55671.id173228.diff
	Wed, Mar 11, 8:33 AM

	F147457372: D55671.id173228.diff
	Wed, Mar 11, 4:28 AM

	Unknown Object (File)
	Tue, Mar 10, 3:18 AM

	Unknown Object (File)
	Mon, Mar 9, 5:26 PM

	Unknown Object (File)
	Sat, Mar 7, 1:09 AM

	Unknown Object (File)
	Fri, Mar 6, 9:12 PM

View All 9 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rGa2b601343bf9: virtual_oss: Combine -d, -l and -L option getopt code

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71271
Build 68154: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Mar 5, 3:58 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 5, 3:58 PM

christos requested review of this revision.Thu, Mar 5, 3:58 PM

Harbormaster completed remote builds in B71201: Diff 173202.Thu, Mar 5, 3:58 PM

christos added a parent revision: D55670: virtual_oss: Define a default control device for /dev/dsp.Thu, Mar 5, 3:58 PM

Fix switch case.

Harbormaster completed remote builds in B71210: Diff 173228.Thu, Mar 5, 9:57 PM

markj added inline comments.Sun, Mar 8, 1:17 AM

usr.sbin/virtual_oss/virtual_oss/main.c
2263	What is the difference between `-d` and `-l`?

markj added inline comments.Sun, Mar 8, 1:19 AM

usr.sbin/virtual_oss/virtual_oss/main.c
2263	Oh, I see, it's the last parameter to dup_profile(). Then you can collapse the calls: ptr = dup_profile(&profile, opt_amp, opt_pol, opt_mute[0], opt_mute[1], c == 'L', c == 'd');

Address Mark's comment.

Harbormaster completed remote builds in B71271: Diff 173376.Sun, Mar 8, 8:01 PM

markj accepted this revision.Tue, Mar 10, 1:19 AM

This revision is now accepted and ready to land.Tue, Mar 10, 1:19 AM

Closed by commit rGa2b601343bf9: virtual_oss: Combine -d, -l and -L option getopt code (authored by christos). · Explain WhyTue, Mar 10, 10:55 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGa2b601343bf9: virtual_oss: Combine -d, -l and -L option getopt code.

Revision Contents
Changeset List

Path

Size

usr.sbin/

virtual_oss/

virtual_oss/

22 lines

Diff 173376

usr.sbin/virtual_oss/virtual_oss/main.c

Loading...