Paths

Table of Contentst

Differential D55671

virtual_oss: Combine -d, -l and -L option getopt code
ClosedPublic
Actions

Authored by christos on Mar 5 2026, 3:58 PM.

Tags

None

Referenced Files

	F151436945: D55671.id.diff
	Wed, Apr 8, 9:53 AM

	Unknown Object (File)
	Wed, Apr 8, 12:36 AM

	Unknown Object (File)
	Wed, Apr 8, 12:23 AM

	Unknown Object (File)
	Sun, Apr 5, 1:14 PM

	Unknown Object (File)
	Fri, Mar 20, 12:21 AM

	Unknown Object (File)
	Thu, Mar 19, 5:49 AM

	Unknown Object (File)
	Wed, Mar 18, 11:36 AM

	Unknown Object (File)
	Wed, Mar 18, 7:40 AM

View All 24 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rGedc9c3ee463e: virtual_oss: Combine -d, -l and -L option getopt code
rGa2b601343bf9: virtual_oss: Combine -d, -l and -L option getopt code

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71201
Build 68084: arc lint + arc unit

Event Timeline

christos created this revision.Mar 5 2026, 3:58 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 5 2026, 3:58 PM

christos requested review of this revision.Mar 5 2026, 3:58 PM

Harbormaster completed remote builds in B71201: Diff 173202.Mar 5 2026, 3:58 PM

christos added a parent revision: D55670: virtual_oss: Introduce virtual_oss_default_control_device rc variable.Mar 5 2026, 3:58 PM

Fix switch case.

Harbormaster completed remote builds in B71210: Diff 173228.Mar 5 2026, 9:57 PM

markj added inline comments.Mar 8 2026, 1:17 AM

usr.sbin/virtual_oss/virtual_oss/main.c
2260	What is the difference between `-d` and `-l`?

markj added inline comments.Mar 8 2026, 1:19 AM

usr.sbin/virtual_oss/virtual_oss/main.c
2260	Oh, I see, it's the last parameter to dup_profile(). Then you can collapse the calls: ptr = dup_profile(&profile, opt_amp, opt_pol, opt_mute[0], opt_mute[1], c == 'L', c == 'd');

Address Mark's comment.

Harbormaster completed remote builds in B71271: Diff 173376.Mar 8 2026, 8:01 PM

markj accepted this revision.Mar 10 2026, 1:19 AM

This revision is now accepted and ready to land.Mar 10 2026, 1:19 AM

Closed by commit rGa2b601343bf9: virtual_oss: Combine -d, -l and -L option getopt code (authored by christos). · Explain WhyTue, Mar 10, 10:55 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGa2b601343bf9: virtual_oss: Combine -d, -l and -L option getopt code.

christos added a commit: rGedc9c3ee463e: virtual_oss: Combine -d, -l and -L option getopt code.Tue, Mar 17, 12:03 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

virtual_oss/

virtual_oss/

29 lines

Diff 173202

usr.sbin/virtual_oss/virtual_oss/main.c

Loading...