Differential D55629

hwpstate_intel: Use 8bit scale instead of percentage scale
ClosedPublic
Actions

Authored by aokblast on Mar 3 2026, 10:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 6, 10:53 AM

	Unknown Object (File)
	Mon, Jul 6, 5:04 AM

	Unknown Object (File)
	Sun, Jul 5, 5:16 AM

	Unknown Object (File)
	Fri, Jun 26, 2:52 AM

	Unknown Object (File)
	Thu, Jun 25, 8:07 AM

	Unknown Object (File)
	Wed, Jun 24, 2:39 PM

	Unknown Object (File)
	Tue, Jun 16, 10:07 AM

	Unknown Object (File)
	Tue, Jun 16, 10:07 AM

View All 39 Files

Subscribers

Details

Reviewers

Commits

rG8452afeb5682: hwpstate_intel: Use 8bit scale instead of percentage scale

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71149
Build 68032: arc lint + arc unit

Event Timeline

aokblast created this revision.Mar 3 2026, 10:17 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2026, 10:17 AM

aokblast requested review of this revision.Mar 3 2026, 10:17 AM

Harbormaster completed remote builds in B71149: Diff 173051.Mar 3 2026, 10:17 AM

aokblast added a reviewer: olce.Mar 4 2026, 5:51 AM

Some suggested changes, looks good.

sys/x86/cpufreq/hwpstate_intel.c
223	In order to send [0;15] to the full [0;255] range (so that 255 is reported when EPB is set to 15), I'd rather use multiply by 17 (please add a small comment about that).
224

Minor fixes

Harbormaster completed remote builds in B71810: Diff 174517.Mar 30 2026, 7:09 AM

olce accepted this revision.Wed, Jun 24, 3:52 PM

This revision is now accepted and ready to land.Wed, Jun 24, 3:52 PM

Closed by commit rG8452afeb5682: hwpstate_intel: Use 8bit scale instead of percentage scale (authored by aokblast). · Explain WhyWed, Jun 24, 6:19 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG8452afeb5682: hwpstate_intel: Use 8bit scale instead of percentage scale.

Herald added a subscriber: ziaee. · View Herald TranscriptWed, Jun 24, 6:19 PM

olce mentioned this in rG66d48f02de0f: hwpstate_intel(4): Comment the EPB to EPP computation.Thu, Jun 25, 12:28 AM

Revision Contents
Changeset List

Path

Size

sys/

x86/

cpufreq/

hwpstate_intel.c

60 lines

Diff 173051

sys/x86/cpufreq/hwpstate_intel.c

Loading...