asmc: code style modernization and minor cleanups
ClosedPublic
Actions

Authored by ngie on Fri, Feb 20, 3:55 AM.

Details

Reviewers

markj
adrian
guest-seuros

Commits

rGe20e26e4e271: asmc: code style modernization and minor cleanups

Summary

Allow ASMC_DEBUG to be treated as a variadic macro.
Add ellipses around sizeof(..) calls.
Reindent some of the lines to better follow style(9) with line wrapping.

A number of other clang-format changes were not taken as they are not
compatible with style(9). A change to the config to improve
compatibility with style(9) is pending.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70843
Build 67726: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Feb 20, 3:55 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 20, 3:55 AM

ngie requested review of this revision.Fri, Feb 20, 3:55 AM

Harbormaster completed remote builds in B70812: Diff 172298.Fri, Feb 20, 3:55 AM

ngie added reviewers: markj, adrian, guest-seuros.Fri, Feb 20, 6:03 AM

guest-seuros accepted this revision.Fri, Feb 20, 5:55 PM

This revision is now accepted and ready to land.Fri, Feb 20, 5:55 PM

Fix compilation errors.

vimdiff... you're such a PITA sometimes...

This revision now requires review to proceed.Sat, Feb 21, 12:12 AM

Harbormaster completed remote builds in B70843: Diff 172353.Sat, Feb 21, 12:13 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 21, 5:32 AM

Closed by commit rGe20e26e4e271: asmc: code style modernization and minor cleanups (authored by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rGe20e26e4e271: asmc: code style modernization and minor cleanups.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

asmc.c

108 lines

Diff 172353

View Options

asmc: code style modernization and minor cleanupsClosedPublicActions