Page MenuHomeFreeBSD
Differential D55394

asmc: code style modernization and minor cleanups
ClosedPublic
Actions

Authored by ngie on Feb 20 2026, 3:55 AM.
Tags
None
Referenced Files
F154034659: D55394.id172298.diff
Sat, Apr 25, 3:37 PM
Unknown Object (File)
Sun, Apr 19, 3:23 PM
Unknown Object (File)
Fri, Apr 17, 2:54 PM
Unknown Object (File)
Mar 21 2026, 12:18 AM
Unknown Object (File)
Mar 20 2026, 1:36 AM
Unknown Object (File)
Mar 13 2026, 8:52 PM
Unknown Object (File)
Mar 12 2026, 3:28 PM
Unknown Object (File)
Mar 12 2026, 7:34 AM
View All 24 Files
Subscribers
imp

Details

Reviewers
markj
adrian
guest-seuros
Commits
rG0770a765a204: asmc: code style modernization and minor cleanups
rG732d45e72d9c: asmc: code style modernization and minor cleanups
rGe20e26e4e271: asmc: code style modernization and minor cleanups
Summary
  • Allow ASMC_DEBUG to be treated as a variadic macro.
  • Add ellipses around sizeof(..) calls.
  • Reindent some of the lines to better follow style(9) with line wrapping.

A number of other clang-format changes were not taken as they are not
compatible with style(9). A change to the config to improve
compatibility with style(9) is pending.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70812
Build 67695: arc lint + arc unit

Event Timeline

ngie created this revision.Feb 20 2026, 3:55 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2026, 3:55 AM
ngie requested review of this revision.Feb 20 2026, 3:55 AM
Harbormaster completed remote builds in B70812: Diff 172298.Feb 20 2026, 3:55 AM
ngie added reviewers: markj, adrian, guest-seuros.Feb 20 2026, 6:03 AM
guest-seuros accepted this revision.Feb 20 2026, 5:55 PM
This revision is now accepted and ready to land.Feb 20 2026, 5:55 PM
ngie updated this revision to Diff 172353.Feb 21 2026, 12:12 AM

Fix compilation errors.

vimdiff... you're such a PITA sometimes...

This revision now requires review to proceed.Feb 21 2026, 12:12 AM
Harbormaster completed remote builds in B70843: Diff 172353.Feb 21 2026, 12:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 21 2026, 5:32 AM
Closed by commit rGe20e26e4e271: asmc: code style modernization and minor cleanups (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rGe20e26e4e271: asmc: code style modernization and minor cleanups.
ngie added a commit: rG732d45e72d9c: asmc: code style modernization and minor cleanups.Sat, Apr 25, 4:36 PM
ngie added a commit: rG0770a765a204: asmc: code style modernization and minor cleanups.

Revision Contents
Changeset List

PathSize
sys/
dev/
asmc/
101 lines

Diff 172298

View Options

sys/dev/asmc/asmc.c

Loading...