Page MenuHomeFreeBSD
Differential D55153

pwd: Add tests
ClosedPublic
Actions

Authored by des on Sat, Feb 7, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 1, 10:43 AM
Unknown Object (File)
Sat, Feb 28, 5:40 PM
Unknown Object (File)
Thu, Feb 26, 11:45 AM
Unknown Object (File)
Tue, Feb 24, 9:45 PM
Unknown Object (File)
Mon, Feb 23, 9:57 PM
Unknown Object (File)
Mon, Feb 23, 9:57 PM
Unknown Object (File)
Sun, Feb 22, 9:36 PM
Unknown Object (File)
Sun, Feb 22, 2:55 PM
View All 17 Files
Subscribers
asomers
imp
ivy

Details

Reviewers
imp
Group Reviewers
tests
Commits
rG11a22ea28ecf: pwd: Add tests
rG36fa67513b33: pwd: Add tests
rG36ec2b1c104f: pwd: Add tests
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70555
Build 67438: arc lint + arc unit

Event Timeline

des created this revision.Sat, Feb 7, 10:53 AM
Herald added subscribers: ivy, imp. · View Herald TranscriptSat, Feb 7, 10:53 AM
des requested review of this revision.Sat, Feb 7, 10:53 AM
Harbormaster completed remote builds in B70488: Diff 171397.Sat, Feb 7, 10:54 AM
des added a parent revision: D55146: pwd: Clean up and adopt POSIX semantics.Sat, Feb 7, 10:54 AM
asomers added a subscriber: asomers.Sat, Feb 7, 3:43 PM
asomers added inline comments.
bin/pwd/tests/pwd_test.sh
27

This line is redundant.

49–57

Shouldn't these two paragraphs belong in the logical test?

des marked 2 inline comments as done.Sat, Feb 7, 4:18 PM
des added inline comments.
bin/pwd/tests/pwd_test.sh
27

It is also harmless.

49–57

No, the test does exactly what its description says.

des marked 2 inline comments as done.Sat, Feb 7, 4:19 PM
imp accepted this revision.Sat, Feb 7, 6:09 PM
This revision is now accepted and ready to land.Sat, Feb 7, 6:09 PM
des updated this revision to Diff 171559.Mon, Feb 9, 5:40 PM

rename directory and symlink so tests are more self-explanatory
add more physical cases

This revision now requires review to proceed.Mon, Feb 9, 5:40 PM
Harbormaster completed remote builds in B70555: Diff 171559.Mon, Feb 9, 5:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 10, 2:29 PM
Closed by commit rG36ec2b1c104f: pwd: Add tests (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rG36ec2b1c104f: pwd: Add tests.
des added a commit: rG36fa67513b33: pwd: Add tests.Sun, Feb 15, 8:58 AM
des added a commit: rG11a22ea28ecf: pwd: Add tests.

Revision Contents
Changeset List

PathSize
bin/
pwd/
8 lines
tests/
4 lines
73 lines
etc/
mtree/
2 lines

Diff 171559

View Options

bin/pwd/Makefile

Loading...
View Options

bin/pwd/tests/Makefile

Loading...
View Options

bin/pwd/tests/pwd_test.sh

Loading...
View Options

etc/mtree/BSD.tests.dist

Loading...