sdhci_fdt_rockchip: Don't return 0 from probe routine
ClosedPublic
Actions

Authored by jhb on Feb 7 2026, 3:46 PM.

Details

Reviewers

Commits

rG06fcab1f02fe: sdhci_fdt_rockchip: Don't return 0 from probe routine
rG3f18463745c9: sdhci_fdt_rockchip: Don't return 0 from probe routine

Summary

The only write to the softc is a no-op (softcs are initialized to all
zeroes), so remove that and just use BUS_PROBE_DEFAULT.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70495
Build 67378: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 7 2026, 3:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 7 2026, 3:46 PM

jhb requested review of this revision.Feb 7 2026, 3:46 PM

jhb added a parent revision: D55158: sdhci_fdt_rockchip: Move ofw_bus_status_okay check.

jhb added a child revision: D55160: arm64: Explicitly use movz.

Harbormaster completed remote builds in B70495: Diff 171413.Feb 7 2026, 3:47 PM

This is not required to build arm64 with GCC (the rest of this stack are fixes needed for that), but is just a cleanup I noticed while fixing the previous patch.

jhb added a reviewer: bnovkov.Feb 7 2026, 3:48 PM

LGTM.

This revision is now accepted and ready to land.Feb 8 2026, 4:39 PM

Closed by commit rG3f18463745c9: sdhci_fdt_rockchip: Don't return 0 from probe routine (authored by jhb). · Explain WhyFeb 9 2026, 4:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3f18463745c9: sdhci_fdt_rockchip: Don't return 0 from probe routine.

jhb added a commit: rG06fcab1f02fe: sdhci_fdt_rockchip: Don't return 0 from probe routine.Apr 24 2026, 5:56 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

sdhci_fdt_rockchip.c

5 lines

Diff 171413

View Options

sys/dev/sdhci/sdhci_fdt_rockchip.c

sdhci_fdt_rockchip: Don't return 0 from probe routineClosedPublicActions