PR: bin/292773
MFC after: 1 week
Details
Details
- Reviewers
jhb markj emaste jrtc27 - Commits
- rG4f7336a93cb8: etcupdate: Do not ignore empty files.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 70202 Build 67085: arc lint + arc unit
Event Timeline
Comment Actions
I'm not very familiar with etcupdate internals but this seems reasonable to me. OTOH I don't know what clutter the comment is referring to.
It'd be nice to add a regression test for this.
| usr.sbin/etcupdate/etcupdate.sh | ||
|---|---|---|
| 250 | Presumably this comment needs to be updated too? | |
Comment Actions
Add regression test for installing empty files.
Verified with the change reverted and applied.
| usr.sbin/etcupdate/etcupdate.sh | ||
|---|---|---|
| 250 | I think the comment is still true (we still ignore generated files, and comment didn't explicitly say empty files)... | |
Comment Actions
It used to be that make distribution generated a lot of empty files and they would indeed clutter the output of etcupdate diff. Did you look at the output of etcupdate diff before and after this change? And/or did you see if there are empty files in /var/db/etcupdate/current?