Differential D54899

libc: document posix_spawnattr_{get,set}procdescp_np(3)
ClosedPublic
Actions

Authored by kib on Mon, Jan 26, 8:13 PM.

Tags

None

Referenced Files

	F144060276: D54899.diff
	Wed, Feb 4, 2:26 AM

	F144033305: D54899.id.diff
	Tue, Feb 3, 4:22 PM

	F144026838: D54899.id170497.diff
	Tue, Feb 3, 2:05 PM

	Unknown Object (File)
	Mon, Feb 2, 4:38 AM

	Unknown Object (File)
	Mon, Feb 2, 4:33 AM

	Unknown Object (File)
	Tue, Jan 27, 6:20 PM

	Unknown Object (File)
	Tue, Jan 27, 6:20 PM

	Unknown Object (File)
	Tue, Jan 27, 3:11 PM

View All 19 Files

Subscribers

Details

Reviewers

asomers
markj
emaste

Commits

rG77c5f29453ed: libc: document posix_spawnattr_{get,set}procdescp_np(3)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Mon, Jan 26, 8:13 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptMon, Jan 26, 8:13 PM

kib requested review of this revision.Mon, Jan 26, 8:13 PM

Reword the unclear and long sentence.

I suggest a few wording changes. Also, fork->vfork, pdfork->pdrfork, and execfd->procdescp.

lib/libc/gen/posix_spawnattr_getprocdescp_np.3
41
45–46
47–48
49–56
58–62
66
67
70
75

This revision now requires changes to proceed.Mon, Jan 26, 8:41 PM

kib marked 9 inline comments as done.Mon, Jan 26, 9:20 PM

kib added inline comments.

lib/libc/gen/posix_spawnattr_getprocdescp_np.3
49–56	vfork is an implementation detail, that can change and that not relevant to the reader. I listed all of them in one xref to make it not a point.
66	Well, it is pdfork(2) part of the procdesc man page that describes flags, and both pdrfork and this place reference it. So I think it is more correct, and more future-proof if the pdrfork is moved into a separate man page. This is my opinion, if you insist, I will change this.

Alan' editing.

asomers accepted this revision.Mon, Jan 26, 9:23 PM

This revision is now accepted and ready to land.Mon, Jan 26, 9:23 PM

Closed by commit rG77c5f29453ed: libc: document posix_spawnattr_{get,set}procdescp_np(3) (authored by kib). · Explain WhyMon, Jan 26, 9:48 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG77c5f29453ed: libc: document posix_spawnattr_{get,set}procdescp_np(3).

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

2 lines

2 lines

posix_spawnattr_getprocdescp_np.3

95 lines

Diff 170490

lib/libc/gen/Makefile.inc

Loading...

lib/libc/gen/posix_spawn.3

Loading...

lib/libc/gen/posix_spawnattr_getprocdescp_np.3

Loading...