Page MenuHomeFreeBSD
Differential D54862

Add posix_spawnattr_get/setexecfd_np(3)
ClosedPublic
Actions

Authored by kib on Sat, Jan 24, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 3, 2:01 PM
Unknown Object (File)
Mon, Feb 2, 3:22 AM
Unknown Object (File)
Fri, Jan 30, 11:32 PM
Unknown Object (File)
Mon, Jan 26, 8:12 PM
Unknown Object (File)
Mon, Jan 26, 11:29 AM
Unknown Object (File)
Mon, Jan 26, 11:23 AM
Unknown Object (File)
Mon, Jan 26, 9:52 AM
Unknown Object (File)
Mon, Jan 26, 9:20 AM
View All 15 Files
Subscribers
imp
ziaee

Details

Reviewers
asomers
markj
emaste
Commits
rG58580dc0c694: libc: document posix_spawnattr_getexecfd_np(3)
rG3f0aea09689f: libc: add posix_spawnattr_{get,set}execfd_np(3)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sat, Jan 24, 10:24 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Jan 24, 10:24 PM
kib requested review of this revision.Sat, Jan 24, 10:24 PM
kib updated this revision to Diff 170359.Sun, Jan 25, 12:26 AM

Some fixes, mostly to the man page typos.
Also accept that spawnattrs might be NULL.

markj added inline comments.Sun, Jan 25, 4:02 PM
lib/libc/gen/posix_spawnattr_getexecfd_np.3
14

posix_spawn.3 should xref this page in the SEE ALSO section.

46
47
48

What's wrong with having O_CLOEXEC set? Doesn't fexecve() work in this case? I didn't test it, but I see that do_execve() acquires a ref on the textvp before calling fdcloseexec().

Certainly O_CLOFORK must not be set.

52
85
kib marked 6 inline comments as done.Sun, Jan 25, 4:18 PM
kib added inline comments.
lib/libc/gen/posix_spawnattr_getexecfd_np.3
48

Of course it is CLOFORK. My bad, I had some discussion about some patch with the CLOFORK author simultaneously and it obviously get mixed.

kib updated this revision to Diff 170402.Sun, Jan 25, 4:19 PM
kib marked an inline comment as done.

Man page fixes

markj accepted this revision.Sun, Jan 25, 5:16 PM
This revision is now accepted and ready to land.Sun, Jan 25, 5:16 PM
Closed by commit rG3f0aea09689f: libc: add posix_spawnattr_{get,set}execfd_np(3) (authored by kib). · Explain WhySun, Jan 25, 5:21 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG3f0aea09689f: libc: add posix_spawnattr_{get,set}execfd_np(3).
kib added a commit: rG58580dc0c694: libc: document posix_spawnattr_getexecfd_np(3).

Revision Contents
Changeset List

PathSize
include/
7 lines
lib/
libc/
gen/
2 lines
5 lines
22 lines
86 lines

Diff 170359

View Options

include/spawn.h

Loading...
View Options

lib/libc/gen/Makefile.inc

Loading...
View Options

lib/libc/gen/Symbol.map

Loading...
View Options

lib/libc/gen/posix_spawn.c

Loading...
View Options

lib/libc/gen/posix_spawnattr_getexecfd_np.3

Loading...