Page MenuHomeFreeBSD
Differential D54795

net80211: in net80211_vap_printf() also use vprintf()
Needs ReviewPublic
Actions

Authored by bz on Tue, Jan 20, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 22, 11:33 PM
Unknown Object (File)
Wed, Jan 21, 9:01 PM
Unknown Object (File)
Wed, Jan 21, 12:10 AM
Unknown Object (File)
Tue, Jan 20, 11:52 PM
Unknown Object (File)
Tue, Jan 20, 10:39 PM
Unknown Object (File)
Tue, Jan 20, 8:16 PM
Unknown Object (File)
Tue, Jan 20, 7:47 PM
Unknown Object (File)
Tue, Jan 20, 6:51 PM
Subscribers
emaste
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
wireless
Summary

While everything else uses vprintf() and net80211_vap_printf()
vlog() the debug output of wlandebug sessions can be weird.
For consistency use vprintf() everywhere to have homogeneous logging.

Sponosred by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70016
Build 66899: arc lint + arc unit

Event Timeline

bz created this revision.Tue, Jan 20, 1:54 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptTue, Jan 20, 1:54 PM
bz requested review of this revision.Tue, Jan 20, 1:54 PM
Harbormaster completed remote builds in B70016: Diff 170120.Tue, Jan 20, 1:55 PM
emaste added a subscriber: emaste.Tue, Jan 20, 2:03 PM
emaste added inline comments.
sys/net80211/ieee80211_freebsd.c
1327

Any reason to keep this commented out?

bz added inline comments.Tue, Jan 20, 2:25 PM
sys/net80211/ieee80211_freebsd.c
1327

Question is whether we want to, at some point, migrate them all to vlog or rather not? See the function below for Adrian's comments left.

I left it as a reminder that there was a problem with it. I had concerns on the previous review.
We need an overall strategy for this (and debug logging, which ideally would go elsewhere... or cease to be printf).

I can remove it though if you want. The problem will stay on the stack in my head.

In some ways this is (and I should add it to the commit message):
Fixes: 0861daf511dc9

bz updated this revision to Diff 170133.Tue, Jan 20, 3:53 PM

Rather than leaving the vlog as a reminder, deal with the TODO comment
in net80211_ic_printf() as well and remove the vlog comment from there.

Harbormaster completed remote builds in B70023: Diff 170133.Tue, Jan 20, 3:53 PM
bz marked an inline comment as done.Fri, Jan 23, 9:35 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
3 lines

Diff 170120

View Options

sys/net80211/ieee80211_freebsd.c

Loading...