Page MenuHomeFreeBSD
Differential D54770

queue.3: splist into slist.3, stailq.3, list.3, and tailq.3
Needs ReviewPublic
Actions

Authored by minsoochoo0122_proton.me on Sun, Jan 18, 10:28 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Feb 2, 6:22 PM
Unknown Object (File)
Sun, Feb 1, 11:50 AM
Unknown Object (File)
Sat, Jan 31, 6:49 AM
Unknown Object (File)
Sun, Jan 25, 2:14 PM
Unknown Object (File)
Sun, Jan 25, 11:21 AM
Unknown Object (File)
Sat, Jan 24, 9:49 PM
Unknown Object (File)
Sat, Jan 24, 9:39 PM
Unknown Object (File)
Fri, Jan 23, 9:02 PM
View All 18 Files
Subscribers
brooks
imp
markj
ziaee

Details

Reviewers
None
Group Reviewers
Contributor Reviews (src)
manpages
Summary

D54753 is too long. I'm splitting this to make review easier.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69998
Build 66881: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Sun, Jan 18, 10:28 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSun, Jan 18, 10:28 PM
minsoochoo0122_proton.me requested review of this revision.Sun, Jan 18, 10:28 PM
Harbormaster completed remote builds in B69976: Diff 170024.Sun, Jan 18, 10:28 PM
minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Sun, Jan 18, 10:29 PM
minsoochoo0122_proton.me added reviewers: Contributor Reviews (src), manpages.
minsoochoo0122_proton.me added a project: Contributor Reviews (src).
minsoochoo0122_proton.me added a child revision: D54753: queue(3): add function-based API.
minsoochoo0122_proton.me added a subscriber: markj.
minsoochoo0122_proton.me mentioned this in D54753: queue(3): add function-based API.Mon, Jan 19, 5:15 PM
brooks added a subscriber: brooks.Mon, Jan 19, 9:52 PM

I like the idea of the split, but I'm not convinced queue.3 should go away entirely. If nothing else this commit fails to remove all references to queue(3) in the tree and I suspect it's in some people's finger memory. I'd suggest transforming queue.3 into an intro-like manpage with a brief comparison of each of the relevant list/queue types.

minsoochoo0122_proton.me updated this revision to Diff 170082.Mon, Jan 19, 10:18 PM

@brooks That's a fair point. I added queue.3 with minimum intro and restored some man pages that can have queue.3 rather than listing all four.

Harbormaster completed remote builds in B69998: Diff 170082.Mon, Jan 19, 10:18 PM

Revision Contents
Changeset List

PathSize
share/
man/
man3/
200 lines
7 lines
437 lines
1483 lines
449 lines
463 lines
512 lines
man9/
11 lines
6 lines
6 lines

Diff 170082

View Options

share/man/man3/Makefile

Loading...
View Options

share/man/man3/arb.3

Loading...
View Options

share/man/man3/list.3

Loading...
View Options

share/man/man3/queue.3

Loading...
View Options

share/man/man3/slist.3

Loading...
View Options

share/man/man3/stailq.3

Loading...
View Options

share/man/man3/tailq.3

Loading...
View Options

share/man/man9/ifnet.9

Loading...
View Options

share/man/man9/mbuf_tags.9

Loading...
View Options

share/man/man9/sysctl_ctx_init.9

Loading...