lib/virtual_oss: don't (over)link to libsamplerate
ClosedPublic
Actions

Authored by brooks on Jan 14 2026, 12:50 PM.

Details

Reviewers

christos
emaste

Commits

rGf3888268299d: lib/virtual_oss: don't (over)link to libsamplerate
rGd78291b0e973: lib/virtual_oss: don't (over)link to libsamplerate

Summary

These plugins require samplerate.h due to virtual_oss's int.h including
it, but don't use any symbols directly so don't link to the library.

Centralize adding the include path.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69872
Build 66755: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 14 2026, 12:50 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 14 2026, 12:50 PM

brooks requested review of this revision.Jan 14 2026, 12:50 PM

Harbormaster completed remote builds in B69872: Diff 169688.Jan 14 2026, 12:50 PM

brooks added a parent revision: D54704: vitual_oss: build system tidying.Jan 14 2026, 12:50 PM

The whole stack of review builds including subdirectories that aren't connected to the build (other then sndio since I didn't have libsndio installed). However, these changes are untested and I've only verified this last change by building and examining the library with nm to verity that they don't include surprising undefined symbols.

christos accepted this revision.Jan 15 2026, 5:58 PM

This revision is now accepted and ready to land.Jan 15 2026, 5:58 PM

By the way, there is a typo in the commit title ("vitual").

Closed by commit rGd78291b0e973: lib/virtual_oss: don't (over)link to libsamplerate (authored by brooks). · Explain WhyJan 16 2026, 9:45 AM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGd78291b0e973: lib/virtual_oss: don't (over)link to libsamplerate.

christos added a commit: rGf3888268299d: lib/virtual_oss: don't (over)link to libsamplerate.Fri, Jan 30, 4:33 PM