vitual_oss: build system tidying
ClosedPublic
Actions

Authored by brooks on Jan 14 2026, 12:50 PM.

Details

Reviewers

christos
emaste

Commits

rG9be3ccda4c90: virtual_oss: build system tidying
rG373c72ad5044: virtual_oss: build system tidying

Summary

general:

find libsamplerate's headers in the temporary sysroot instead of digging in the source tree.
use LIBADD where possible

lib/virtual_oss:

centralize SHLIBDIR define
centralize include path for internal headers
don't try to find libsamplerate directly in .OBJDIR

No functional changes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69871
Build 66754: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 14 2026, 12:50 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 14 2026, 12:50 PM

brooks requested review of this revision.Jan 14 2026, 12:50 PM

Harbormaster completed remote builds in B69871: Diff 169687.Jan 14 2026, 12:50 PM

brooks added a parent revision: D54703: virtual_oss: build commands/libs in parallel.Jan 14 2026, 12:50 PM

brooks added a child revision: D54705: lib/virtual_oss: don't (over)link to libsamplerate.

Neither lib/virtual_oss nor usr.sbin/virtual_oss build with this patch:

root@freebsd:/mnt/src/lib/virtual_oss # make
Building /usr/obj/mnt/src/amd64.amd64/lib/virtual_oss/null/null.pico
In file included from /mnt/src/lib/virtual_oss/null/null.c:39:
/mnt/src/usr.sbin/virtual_oss/virtual_oss/int.h:33:10: fatal error: 'samplerate.h' file not found
   33 | #include <samplerate.h>

In D54704#1249776, @christos wrote:

Neither lib/virtual_oss nor usr.sbin/virtual_oss build with this patch:

root@freebsd:/mnt/src/lib/virtual_oss # make
Building /usr/obj/mnt/src/amd64.amd64/lib/virtual_oss/null/null.pico
In file included from /mnt/src/lib/virtual_oss/null/null.c:39:
/mnt/src/usr.sbin/virtual_oss/virtual_oss/int.h:33:10: fatal error: 'samplerate.h' file not found
   33 | #include <samplerate.h>

Direct manual building when you depend on a library that isn't installed isn't supported in FreeBSD's build system. You must build in a make buildenv environment having previously bootstrapped includes (it also won't link since libsamplerate presumably isn't installed.)

christos accepted this revision.Jan 15 2026, 5:57 PM

This revision is now accepted and ready to land.Jan 15 2026, 5:57 PM

Closed by commit rG373c72ad5044: virtual_oss: build system tidying (authored by brooks). · Explain WhyFri, Jan 16, 9:45 AM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG373c72ad5044: virtual_oss: build system tidying.

christos added a commit: rG9be3ccda4c90: virtual_oss: build system tidying.Fri, Jan 30, 4:33 PM