makefs: tests: Fix -D flag test
ClosedPublic
Actions

Authored by jlduran on Dec 31 2025, 1:40 AM.

Details

Reviewers

ngie
emaste

Commits

rGb10369daede7: makefs: tests: Fix -D flag test
rG96efda9cd556: makefs: tests: Fix -D flag test

Summary

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specify it as the last argument on the command line, not as the
argument to -F.

This change does exactly that. Also bug #192839 has already been fixed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69538
Build 66421: arc lint + arc unit

Event Timeline

jlduran created this revision.Dec 31 2025, 1:40 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 31 2025, 1:40 AM

jlduran requested review of this revision.Dec 31 2025, 1:40 AM

Harbormaster completed remote builds in B69538: Diff 168790.Dec 31 2025, 1:40 AM

jlduran added a parent revision: D54427: makefs: tests: Cleanup and remove default flags.Dec 31 2025, 1:40 AM

jlduran added a child revision: D54429: makefs: tests: Fix timestamp-related tests.

jlduran added reviewers: ngie, emaste.Dec 31 2025, 1:49 AM

jlduran added inline comments.Dec 31 2025, 2:27 AM

usr.sbin/makefs/tests/makefs_cd9660_tests.sh
64	It is worth mentioning that makefs can still crash mtree if an invalid specification, (invalid type, or no type) is passed. This will be addressed separately.