While here, fix a few length checks that did not handle overflow.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 69528 Build 66411: arc lint + arc unit
Event Timeline
| sys/netlink/netlink.h | ||
|---|---|---|
| 260 | That's compat with Linux definition, let's keep as is - https://github.com/torvalds/linux/blob/b69053dd3ffbc0d2dedbbc86182cdef6f641fe1b/tools/include/uapi/linux/netlink.h#L232 | |
| sys/netlink/netlink_snl.h | ||
| 56 | Looks like it's already defined in netlink.h, so can prob be removed | |
| sys/netlink/netlink.h | ||
|---|---|---|
| 260 | We already use a (uint16_t) cast instead in netlink_ctl.h (a 3rd place that defines many similar macros, but with subtle differences), so we already disagree on signed vs unsigned for this macro. Keeping this signed will require casts in various other places compared to consistently using unsigned everywhere. | |
| sys/netlink/netlink_snl.h | ||
| 56 | There are lots of duplicated macros between these two files, sometimes with subtly different definitions, and I'm not sure how much will break trying to clean up that mess. | |