geom(9): struct bio KBI fix
Needs ReviewPublic
Actions

Authored by khng on Sat, Dec 20, 7:56 PM.

Details

Reviewers

imp
jhibbits
delphij
kib

Summary

The struct bio was changed after cb85c2e2e995 on the branch. To fix
this, move BIO_ERROR flag to another value, and now BIO_ERROR_COMPAT
occupies 0x1 instead. Also, introduce b_error_compat field at the place
where the old bio_error was.

This allows non-CAM(9) disk drivers and software volume manager modules
compiled against 15.0-RELEASE kernel to work on 15-STABLE kernel again.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69417
Build 66300: arc lint + arc unit

Event Timeline

khng created this revision.Sat, Dec 20, 7:56 PM

Herald added a subscriber: olce. · View Herald TranscriptSat, Dec 20, 7:56 PM

khng requested review of this revision.Sat, Dec 20, 7:56 PM

Harbormaster completed remote builds in B69415: Diff 168474.Sat, Dec 20, 7:56 PM

khng edited the summary of this revision. (Show Details)Sat, Dec 20, 7:58 PM

khng planned changes to this revision.Sat, Dec 20, 8:03 PM

g_io_request will empty bio_error_compat as well.

Harbormaster completed remote builds in B69416: Diff 168475.Sat, Dec 20, 8:16 PM

Harbormaster completed remote builds in B69417: Diff 168476.Sat, Dec 20, 8:19 PM

So a few words about why this is useful. Our KBI commitments on 15.x is fuzzy at best. What does this enable?

In D54327#1241511, @imp wrote:

So a few words about why this is useful. Our KBI commitments on 15.x is fuzzy at best. What does this enable?

Non-cam(9) drivers or software volume manager implementations not maintained in the FreeBSD-src tree would benefit from that. Should that goes into the commit comment as well?

khng edited the summary of this revision. (Show Details)Sun, Dec 21, 1:18 AM

khng added a reviewer: kib.Sun, Dec 21, 6:03 AM