ktls: Capture initial tls seqno at time offload is initiated
ClosedPublic
Actions

Authored by gallatin on Wed, Dec 17, 8:00 PM.

Details

Reviewers

jhb
np

Commits

rG4d692068f685: ktls: Capture initial tls seqno at time offload is initiated

Summary

Some drivers want the TLS seqno when offload starts. Capture this for them by (ab)using the tls next_seqno field.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

gallatin created this revision.Wed, Dec 17, 8:00 PM

Herald added subscribers: glebius, imp. · View Herald TranscriptWed, Dec 17, 8:00 PM

gallatin requested review of this revision.Wed, Dec 17, 8:00 PM

Maybe to make it clearer we can change the struct to use a union of next_seqno and initial_seqno which won't change the ABI but will let us document it in the header and be more clear about the intent?

added union for next_seqno / initial offload seqno to provide a better description & preserve ABI, as suggested by @jhb

In D54275#1240636, @jhb wrote:

Maybe to make it clearer we can change the struct to use a union of next_seqno and initial_seqno which won't change the ABI but will let us document it in the header and be more clear about the intent?

Good idea.. Just updated the diff to do that.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Dec 21, 2:47 PM

Closed by commit rG4d692068f685: ktls: Capture initial tls seqno at time offload is initiated (authored by gallatin). · Explain Why

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rG4d692068f685: ktls: Capture initial tls seqno at time offload is initiated.

Herald added a subscriber: olce. · View Herald TranscriptSun, Dec 21, 2:47 PM