Page MenuHomeFreeBSD
Differential D54192

sound: Merge midi_destroy() with midi_uninit()
ClosedPublic
Actions

Authored by christos on Dec 12 2025, 3:21 PM.
Tags
None
Referenced Files
F157247788: D54192.diff
Tue, May 19, 4:47 PM
Unknown Object (File)
Mon, May 18, 7:06 PM
Unknown Object (File)
Sat, May 9, 12:25 AM
Unknown Object (File)
Tue, Apr 28, 11:07 AM
Unknown Object (File)
Mon, Apr 27, 5:38 AM
Unknown Object (File)
Sat, Apr 25, 5:31 AM
Unknown Object (File)
Sat, Apr 25, 12:33 AM
Unknown Object (File)
Thu, Apr 23, 10:12 AM
View All 42 Files
Subscribers
imp
meka_tilda.center

Details

Reviewers
markj
emaste
Commits
rG8c005f3da817: sound: Merge midi_destroy() with midi_uninit()
rGd912ea5879cd: sound: Merge midi_destroy() with midi_uninit()
Summary

Also always call MPU_UNINIT(). It does not make sense not to if we are
deallocating everything.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69207
Build 66090: arc lint + arc unit

Event Timeline

christos created this revision.Dec 12 2025, 3:21 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 12 2025, 3:21 PM
christos requested review of this revision.Dec 12 2025, 3:21 PM
Harbormaster completed remote builds in B69203: Diff 167922.Dec 12 2025, 3:21 PM
christos mentioned this in D54126: sound: Retire midi_devs and mstat_lock.Dec 12 2025, 3:26 PM
christos updated this revision to Diff 167927.Dec 12 2025, 4:08 PM

Reflect changes in D54126.

Harbormaster completed remote builds in B69207: Diff 167927.Dec 12 2025, 4:08 PM
christos added a parent revision: D54126: sound: Retire midi_devs and mstat_lock.Dec 12 2025, 4:10 PM
markj accepted this revision.Dec 14 2025, 4:00 PM
This revision is now accepted and ready to land.Dec 14 2025, 4:00 PM
christos mentioned this in D54129: sound: Retire snd_midi->qlock.Dec 15 2025, 3:07 PM
meka_tilda.center added a subscriber: meka_tilda.center.Dec 25 2025, 1:30 PM
Closed by commit rGd912ea5879cd: sound: Merge midi_destroy() with midi_uninit() (authored by christos). · Explain WhyJan 2 2026, 4:59 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGd912ea5879cd: sound: Merge midi_destroy() with midi_uninit().
christos added a commit: rG8c005f3da817: sound: Merge midi_destroy() with midi_uninit().Jan 9 2026, 11:28 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
midi/
57 lines

Diff 167927

View Options

sys/dev/sound/midi/midi.c

Loading...