sound: Do not free snd_midi->{in,out}q unconditionally in midi_uninit()
AbandonedPublic
Actions

Authored by christos on Dec 8 2025, 5:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 2, 5:57 AM

	Unknown Object (File)
	Sun, Sep 20, 3:40 AM

	Unknown Object (File)
	Sun, Sep 20, 3:06 AM

	Unknown Object (File)
	Sun, Sep 20, 2:54 AM

	Unknown Object (File)
	Tue, Sep 8, 4:54 AM

	Unknown Object (File)
	Mon, Sep 7, 11:13 AM

	Unknown Object (File)
	Mon, Sep 7, 6:10 AM

	Unknown Object (File)
	Sep 6 2026, 3:56 PM

View All 53 Files

Subscribers

imp

Details

Reviewers

markj
emaste

Summary

Include the same check as in midi_init(). There is a possibility that
one of those can be NULL.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69134
Build 66017: arc lint + arc unit

Event Timeline

christos created this revision.Dec 8 2025, 5:53 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2025, 5:53 PM

Harbormaster completed remote builds in B69133: Diff 167730.Dec 8 2025, 5:53 PM

christos requested review of this revision.Dec 8 2025, 5:53 PM

Abandoned D54134. Update.

Harbormaster completed remote builds in B69134: Diff 167731.Dec 8 2025, 5:55 PM

free(NULL) is fine, and does nothing. There is a lot of code which depends on this.

christos abandoned this revision.Dec 10 2025, 2:39 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

midi/

midi.c

6 lines

Diff 167731

View Options

sound: Do not free snd_midi->{in,out}q unconditionally in midi_uninit()AbandonedPublicActions