Page MenuHomeFreeBSD
Differential D54134

sound: Retire M_MIDI and use M_DEVBUF
AbandonedPublic
Actions

Authored by christos on Dec 8 2025, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 29, 4:17 AM
Unknown Object (File)
Sun, Dec 28, 5:30 PM
Unknown Object (File)
Fri, Dec 26, 6:32 PM
Unknown Object (File)
Thu, Dec 25, 11:49 PM
Unknown Object (File)
Thu, Dec 25, 2:23 AM
Unknown Object (File)
Dec 17 2025, 6:44 PM
Unknown Object (File)
Dec 17 2025, 1:46 PM
Unknown Object (File)
Dec 16 2025, 7:13 PM
View All 14 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Summary

Not sure why we need a separate malloc type here.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69132
Build 66015: arc lint + arc unit

Event Timeline

christos created this revision.Dec 8 2025, 5:50 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 8 2025, 5:50 PM
christos requested review of this revision.Dec 8 2025, 5:50 PM
Harbormaster completed remote builds in B69132: Diff 167729.Dec 8 2025, 5:50 PM
markj added a comment.Dec 8 2025, 5:53 PM

You never "need" a separate malloc() type. It just helps maintain accounting to see which subsystems are using memory. I don't see why it's useful to remove this.

christos abandoned this revision.Dec 8 2025, 5:54 PM
christos mentioned this in D54135: sound: Do not free snd_midi->{in,out}q unconditionally in midi_uninit().Dec 8 2025, 5:55 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
midi/
3 lines
21 lines
7 lines

Diff 167729

View Options

sys/dev/sound/midi/midi.h

Loading...
View Options

sys/dev/sound/midi/midi.c

Loading...
View Options

sys/dev/sound/midi/mpu401.c

Loading...