Page MenuHomeFreeBSD
Differential D54130

sound: Unlock around uiomove() in midi_{read,write}()
Needs ReviewPublic
Actions

Authored by christos on Mon, Dec 8, 4:03 PM.
Tags
None
Referenced Files
F139427154: D54130.id167716.diff
Thu, Dec 11, 11:22 PM
F139424968: D54130.id.diff
Thu, Dec 11, 10:45 PM
F139384662: D54130.diff
Thu, Dec 11, 1:21 PM
Subscribers
imp

Details

Reviewers
markj
emaste
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69128
Build 66011: arc lint + arc unit

Event Timeline

christos created this revision.Mon, Dec 8, 4:03 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Dec 8, 4:03 PM
christos requested review of this revision.Mon, Dec 8, 4:03 PM
Harbormaster completed remote builds in B69128: Diff 167716.Mon, Dec 8, 4:03 PM
christos added a parent revision: D54129: sound: Retire snd_midi->qlock.Mon, Dec 8, 4:03 PM
emaste added inline comments.Tue, Dec 9, 7:00 PM
sys/dev/sound/midi/midi.c
474

are there any struct snd_midimembers that could be invalid after dropping and reacquiring the lock? E.g. could m->flags & M_RX no longer be true?

christos added inline comments.Thu, Dec 11, 11:29 AM
sys/dev/sound/midi/midi.c
474

The only place where M_RX gets cleared is in midi_close(), so I'm not sure we should worry about this, since by that time we'll have closed and midi_read() will just need to flush. Or am I missing something?

christos mentioned this in D54129: sound: Retire snd_midi->qlock.Thu, Dec 11, 11:37 AM
markj added inline comments.Thu, Dec 11, 2:19 PM
sys/dev/sound/midi/midi.c
551

used is calculated above: used = MIN(MIDIQ_AVAIL(m->outq), uio->uio_resid). What if the amount of available space changed while the lock was dropped?

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
midi/
8 lines

Diff 167716

View Options

sys/dev/sound/midi/midi.c

Loading...