LinuxKPI: pci: fix pcie_get_speed_cap()
ClosedPublic
Actions

Authored by bz on Nov 21 2025, 6:00 PM.

Details

Reviewers

emaste
dumbbell

Commits

rGc22f46da9d10: LinuxKPI: pci: fix pcie_get_speed_cap()
rGfa24602ca628: LinuxKPI: pci: fix pcie_get_speed_cap()

Summary

pcie_get_speed_cap() has a hard coded skip of 3 devices at the
beginning. It is either called on a pdev or on a result from
pci_upstream_bridge(). In the latter case skipping another three
devices might get us to acpi0 or nexus, neither of which is a
PCI device still and pci_get_vendor() will panic() on that.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 68788
Build 65671: arc lint + arc unit

Event Timeline

bz created this revision.Nov 21 2025, 6:00 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 21 2025, 6:00 PM

bz requested review of this revision.Nov 21 2025, 6:00 PM

Harbormaster completed remote builds in B68788: Diff 166920.Nov 21 2025, 6:00 PM

I've applied this to my local tree for testing

I've run with this since Sep 17 apparently even though my amdgpu was only useable for ~4 weeks during that time frame.

@emaste should I just put this into main and stable/15 and we'll see?

Also @jhb from looking at the code, on which PCI devices should it be called? I am still confused by the (original) naming of "root". I would assume it's supposedly called on a pcib. Is that correct?