Page MenuHomeFreeBSD
Differential D53835

tpm20: Disable the entropy harvester when suspending
AbandonedPublic
Actions

Authored by markj on Nov 19 2025, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 10, 3:30 PM
Unknown Object (File)
Sun, Dec 28, 1:09 AM
Unknown Object (File)
Dec 14 2025, 10:14 AM
Unknown Object (File)
Dec 13 2025, 3:21 PM
Unknown Object (File)
Dec 10 2025, 1:17 AM
Unknown Object (File)
Dec 4 2025, 4:25 AM
Unknown Object (File)
Dec 3 2025, 3:53 AM
Unknown Object (File)
Dec 2 2025, 11:23 AM
View All 24 Files
Subscribers
emaste
garga
imp
kevans

Details

Reviewers
obrien
garga
Summary

Untested.

Fixes: 3deb21f1afd5 ("random: TPM_HARVEST should have been named RANDOM_ENABLE_TPM")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68751
Build 65634: arc lint + arc unit

Event Timeline

markj created this revision.Nov 19 2025, 9:10 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 19 2025, 9:10 PM
markj requested review of this revision.Nov 19 2025, 9:10 PM
Harbormaster completed remote builds in B68748: Diff 166803.Nov 19 2025, 9:10 PM
emaste added a subscriber: emaste.Nov 19 2025, 9:12 PM
garga requested changes to this revision.Nov 19 2025, 9:20 PM
garga added a subscriber: garga.
garga added inline comments.
sys/dev/tpm/tpm20.c
253

It fails to build due to lack of return

/usr/src/sys/dev/tpm/tpm20.c:254:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
  254 | }
      | ^
This revision now requires changes to proceed.Nov 19 2025, 9:20 PM
markj updated this revision to Diff 166806.Nov 19 2025, 9:23 PM

Fix a compile error

Harbormaster completed remote builds in B68749: Diff 166806.Nov 19 2025, 9:23 PM
markj marked an inline comment as done.Nov 19 2025, 9:24 PM
markj added inline comments.
sys/dev/tpm/tpm20.c
253

Sorry, I forgot to squash a fixup commit.

markj updated this revision to Diff 166816.Nov 19 2025, 9:54 PM
markj marked an inline comment as done.

Upon resume, schedule harvesting further in the future.

Harbormaster completed remote builds in B68751: Diff 166816.Nov 19 2025, 9:54 PM
kevans added a subscriber: kevans.Nov 22 2025, 3:08 AM
garga accepted this revision.Nov 24 2025, 9:47 AM

With most recent modifications it works as expected

This revision is now accepted and ready to land.Nov 24 2025, 9:47 AM
garga requested changes to this revision.Dec 11 2025, 12:14 PM

@obrien @markj as I mentioned on bugzilla, this patch changed the behavior but still doesn't fix it

This revision now requires changes to proceed.Dec 11 2025, 12:14 PM
markj abandoned this revision.Wed, Jan 7, 9:41 PM

I will post a patch to just disable tpm in GENERIC. Sorry for the delay.

Revision Contents
Changeset List

PathSize
sys/
dev/
tpm/
1 line
19 lines
1 line
1 line

Diff 166816

View Options

sys/dev/tpm/tpm20.h

Loading...
View Options

sys/dev/tpm/tpm20.c

Loading...
View Options

sys/dev/tpm/tpm_crb.c

Loading...
View Options

sys/dev/tpm/tpm_tis_core.c

Loading...