Page MenuHomeFreeBSD
Differential D53835

tpm20: Disable the entropy harvester when suspending
Needs ReviewPublic
Actions

Authored by markj on Wed, Nov 19, 9:10 PM.
Tags
None
Referenced Files
F136871384: D53835.id166806.diff
Thu, Nov 20, 7:00 AM
Unknown Object (File)
Thu, Nov 20, 1:24 AM
Unknown Object (File)
Thu, Nov 20, 12:44 AM
Unknown Object (File)
Thu, Nov 20, 12:13 AM
Unknown Object (File)
Thu, Nov 20, 12:00 AM
Unknown Object (File)
Wed, Nov 19, 11:56 PM
Unknown Object (File)
Wed, Nov 19, 11:56 PM
Unknown Object (File)
Wed, Nov 19, 11:45 PM
View All 12 Files
Subscribers
emaste
garga
imp

Details

Reviewers
obrien
garga
Summary

Untested.

Fixes: 3deb21f1afd5 ("random: TPM_HARVEST should have been named RANDOM_ENABLE_TPM")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68749
Build 65632: arc lint + arc unit

Event Timeline

markj created this revision.Wed, Nov 19, 9:10 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 19, 9:10 PM
markj requested review of this revision.Wed, Nov 19, 9:10 PM
Harbormaster completed remote builds in B68748: Diff 166803.Wed, Nov 19, 9:10 PM
emaste added a subscriber: emaste.Wed, Nov 19, 9:12 PM
garga requested changes to this revision.Wed, Nov 19, 9:20 PM
garga added a subscriber: garga.
garga added inline comments.
sys/dev/tpm/tpm20.c
253

It fails to build due to lack of return

/usr/src/sys/dev/tpm/tpm20.c:254:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
  254 | }
      | ^
This revision now requires changes to proceed.Wed, Nov 19, 9:20 PM
markj updated this revision to Diff 166806.Wed, Nov 19, 9:23 PM

Fix a compile error

Harbormaster completed remote builds in B68749: Diff 166806.Wed, Nov 19, 9:23 PM
markj marked an inline comment as done.Wed, Nov 19, 9:24 PM
markj added inline comments.
sys/dev/tpm/tpm20.c
253

Sorry, I forgot to squash a fixup commit.

markj updated this revision to Diff 166816.Wed, Nov 19, 9:54 PM
markj marked an inline comment as done.

Upon resume, schedule harvesting further in the future.

Harbormaster completed remote builds in B68751: Diff 166816.Wed, Nov 19, 9:54 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
tpm/
1 line
18 lines
1 line
1 line

Diff 166806

View Options

sys/dev/tpm/tpm20.h

Loading...
View Options

sys/dev/tpm/tpm20.c

Loading...
View Options

sys/dev/tpm/tpm_crb.c

Loading...
View Options

sys/dev/tpm/tpm_tis_core.c

Loading...