inotify: Work around the vput() bug directly
ClosedPublic
Actions

Authored by markj on Sat, Nov 15, 6:03 PM.

Details

Reviewers

kib
mjg
olce

Commits

rG76883b793db8: inotify: Work around the vput() bug directly
rG1f6e3abf4171: inotify: Work around the vput() bug directly
rGebc17879f088: inotify: Work around the vput() bug directly

Summary

For 15.0, apply a minimal fix which at least ensures that inotify can't
trigger the latent race described in commit 99cb3dca4773 ("vnode: Rework
vput() to avoid holding the vnode lock after decrementing").

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68672
Build 65555: arc lint + arc unit

Event Timeline

markj created this revision.Sat, Nov 15, 6:03 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 15, 6:03 PM

markj requested review of this revision.Sat, Nov 15, 6:03 PM

Harbormaster completed remote builds in B68672: Diff 166515.Sat, Nov 15, 6:03 PM

kib accepted this revision.Sat, Nov 15, 6:07 PM

This revision is now accepted and ready to land.Sat, Nov 15, 6:07 PM

olce accepted this revision.Sat, Nov 15, 7:28 PM

Closed by commit rGebc17879f088: inotify: Work around the vput() bug directly (authored by markj). · Explain WhySun, Nov 16, 6:24 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGebc17879f088: inotify: Work around the vput() bug directly.

markj added a commit: rG1f6e3abf4171: inotify: Work around the vput() bug directly.Wed, Nov 19, 4:17 PM

cperciva added a commit: rG76883b793db8: inotify: Work around the vput() bug directly.Mon, Nov 24, 5:31 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_inotify.c

9 lines

Diff 166515

View Options

inotify: Work around the vput() bug directlyClosedPublicActions