Page MenuHomeFreeBSD
Differential D53554

sound: Retire feedertab_entry
ClosedPublic
Actions

Authored by christos on Nov 3 2025, 3:30 PM.
Tags
None
Referenced Files
F154294665: D53554.id166217.diff
Mon, Apr 27, 4:15 PM
F154201917: D53554.id.diff
Mon, Apr 27, 1:49 AM
Unknown Object (File)
Sat, Apr 25, 11:21 PM
Unknown Object (File)
Sat, Apr 25, 1:25 PM
Unknown Object (File)
Fri, Apr 24, 5:47 PM
Unknown Object (File)
Wed, Apr 22, 4:12 AM
Unknown Object (File)
Wed, Apr 22, 12:31 AM
Unknown Object (File)
Tue, Apr 21, 5:11 PM
View All 60 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG2acd16ce68be: sound: Retire feedertab_entry
rGc24ca02c4c85: sound: Retire feedertab_entry
Summary

Have an SLIST of feeder_class directly. This way we simplify the code,
and also avoid the additional malloc()/free() for each entry.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Nov 3 2025, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2025, 3:30 PM
christos requested review of this revision.Nov 3 2025, 3:30 PM
Harbormaster completed remote builds in B68378: Diff 165738.Nov 3 2025, 3:30 PM
christos added a parent revision: D53553: sound: Simplify feeder_getclass().Nov 3 2025, 3:30 PM
christos added a child revision: D53555: sound: Retire feeder_class->data.
markj added inline comments.Nov 3 2025, 5:37 PM
sys/dev/sound/pcm/feeder.c
44

How is this list locked?

71

This loop can be replaced by SLIST_INIT(&feedertab);

christos updated this revision to Diff 165803.Nov 4 2025, 12:44 PM
christos marked an inline comment as done.

Address Mark's comment.

Harbormaster completed remote builds in B68405: Diff 165803.Nov 4 2025, 12:44 PM
christos added inline comments.Nov 4 2025, 12:45 PM
sys/dev/sound/pcm/feeder.c
44

It isn't. This list is created once after sound.ko has been loaded, and destroyed on unload. There is no adding/removing in the meantime.

markj accepted this revision.Nov 4 2025, 12:51 PM
This revision is now accepted and ready to land.Nov 4 2025, 12:51 PM
Closed by commit rGc24ca02c4c85: sound: Retire feedertab_entry (authored by christos). · Explain WhyNov 11 2025, 12:08 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGc24ca02c4c85: sound: Retire feedertab_entry.
christos added a commit: rG2acd16ce68be: sound: Retire feedertab_entry.Nov 18 2025, 12:52 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
1 line
37 lines

Diff 166217

View Options

sys/dev/sound/pcm/feeder.h

Loading...
View Options

sys/dev/sound/pcm/feeder.c

Loading...