tpm: crb: add support for the Pluton startmethod
Needs ReviewPublic
Actions

Authored by kevans on Tue, Nov 11, 1:55 AM.

Details

Reviewers

jhibbits
obrien
mw
imp

Summary

The Pluton startmethod uses a simple doorbell mechanism to wakeup the
TPM unit after we've issued various forms of state change, with the
registers to use specified in the startmethod-specific segment of the
TPM2 table (up to 12 bytes after the StartMethod).

At the very least, this is the kind of TPM in use by my AMD Zen 4-based
Minisforum machine.

Test Plan

Combinations tested:

Minisforum AI X1 (CRB + Pluton startmethod)
bhyve w/ swtpm (Traditional CRB)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68532
Build 65415: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Tue, Nov 11, 1:55 AM

kevans created this revision.

Harbormaster completed remote builds in B68532: Diff 166191.Tue, Nov 11, 1:55 AM

kevans added a parent revision: D53682: tpm: crb: factor out idle/ready state transitions.Tue, Nov 11, 1:55 AM

Add missing size check to the startmethod _attach()

Harbormaster completed remote builds in B68534: Diff 166195.Tue, Nov 11, 4:40 AM

kevans edited the test plan for this revision. (Show Details)Tue, Nov 11, 5:13 PM

This might be because Juniper's code base isn't up to date with 16-current:
/w/main/src/sys/dev/tpm/tpm_crb.c:104:14: error: use of undeclared identifier 'ACPI_TPM2_COMMAND_BUFFER_WITH_PLUTON'

.acpi_sm = ACPI_TPM2_COMMAND_BUFFER_WITH_PLUTON,
           ^

/w/main/src/sys/dev/tpm/tpm_crb.c:151:25: error: invalid application of 'sizeof' to an incomplete type 'const struct tpmcrb_sm_cfg_map[]'

for (size_t i = 0; i < nitems(tpmcrb_sm_cfg_map); i++) {
                       ^~~~~~~~~~~~~~~~~~~~~~~~~

/w/main/src/sys/sys/param.h:321:26: note: expanded from macro 'nitems'
#define nitems(x) (sizeof((x)) / sizeof((x)[0]))

^~~~~

2 errors generated.

sys/dev/tpm/tpm_crb.c
590–591	No thrilled by non-ISO-C/non-BSD types being used. I guess you're trying to match our data types used (or ACPI specification data type definitions) somewhere in other ACPI code?

Hmm, the definition came in here:

commit 58308fadece25ae4c12bd2f4dce3d73d9c23be43
Author: Jung-uk Kim <jkim@FreeBSD.org>
Date:   Wed Apr 9 23:51:28 2025 -0400

    Import ACPICA 20250404
    
    (cherry picked from commit 97a7606d897edfa3089cb04eea70096a1f9cf734)

sys/dev/tpm/tpm_crb.c
590–591	Yeah,, I was initially trying to be consistent with other ACPI code, though I see that even sys/dev/acpica can't seem to decide which way we really want to be. On a second glance, though, uint*_t does seem to be more popular by a pretty large margin.

Revision Contents
Changeset List

Path

Size

sys/

dev/

tpm/

tpm_crb.c

203 lines

Diff 166191

View Options

tpm: crb: add support for the Pluton startmethodNeeds ReviewPublicActions