tpm: crb: factor out idle/ready state transitions
ClosedPublic
Actions

Authored by kevans on Tue, Nov 11, 1:55 AM.

Details

Reviewers

jhibbits
obrien
mw
imp

Commits

rGcca34aa1d005: tpm: crb: factor out idle/ready state transitions

Summary

Some TPM implementations have a different start method that requires
an additional notification for some state changes; for instance, the
"Pluton" start method. Just factor these transitions out for now, and
the coming commits will introduce points that the start method can hook
in at.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans requested review of this revision.Tue, Nov 11, 1:55 AM

kevans created this revision.

Harbormaster completed remote builds in B68531: Diff 166190.Tue, Nov 11, 1:55 AM

kevans added a child revision: D53683: tpm: crb: add support for the Pluton startmethod.Tue, Nov 11, 1:55 AM

This patch didn't make my Juniper EX4000 catch-fire-and-burn.

obrien added inline comments.Fri, Nov 14, 2:59 AM

sys/dev/tpm/tpm_crb.c
310	Why -1 and not just 0 given you compare "> 0"? 0 as a wait makes more sense to me.
387–388	Any idea why this line is show as a diff?

kevans marked 2 inline comments as done.Fri, Nov 14, 3:10 AM

kevans added inline comments.

sys/dev/tpm/tpm_crb.c
310	I started with -1 and decided that 0 made more sense as I was cleaning up (below was originally `timeout >= 0`), forgot to clean this up- whoops.
387–388	Unclear... hexdump of the diff doesn't show anything of interest, and git-diff also renders it as a difference.