Remove ${OBJDUMP} make variable as it is not used by the base system
ClosedPublic
Actions

Authored by emaste on May 19 2016, 7:26 PM.

Details

Reviewers

brooks
andrew
smh
bdrewery

Commits

rS303392: Remove ${OBJDUMP} as it is not used by the base system

Summary

It was added to sys.mk relatively recently in rS274503 for EFI builds but is no longer used in the base system

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 16579.May 19 2016, 7:26 PM

emaste retitled this revision from to Remove ${OBJDUMP} make variable as it is not used by the base system.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: bdrewery, andrew, smh.

bdrewery accepted this revision.May 19 2016, 7:27 PM

bdrewery edited edge metadata.

This revision is now accepted and ready to land.May 19 2016, 7:27 PM

emaste added a reviewer: brooks.May 19 2016, 7:28 PM

I don't object, but we use it in CheriBSD so I'll have to revert this change there.

I don't object, but we use it in CheriBSD so I'll have to revert this change there.

Ah, we should be able to get the equivalent of the -x, -r, and -s options from readelf, but not -S or -D which are probably the most interesting :(

In D6460#136959, @emaste wrote:

I don't object, but we use it in CheriBSD so I'll have to revert this change there.

Ah, we should be able to get the equivalent of the -x, -r, and -s options from readelf, but not -S or -D which are probably the most interesting :(

Yeah, we have a WANT_DUMP make file option to that runs ${OBJDUMP} -xrsSD on programs (and shortly shared libraries) to help understand instruction traces.

In D6460#136996, @brooks wrote:

Yeah, we have a WANT_DUMP make file option to that runs ${OBJDUMP} -xrsSD on programs (and shortly shared libraries) to help understand instruction traces.

Ok, my proposal: I commit this for now, you can carry the revert in CheriBSD, and we'll subsequently see about improving non-binutils tools (e.g. LLVM objdump) or finding a clean way to use an external toolchain objdump.

Closed by commit rS303392: Remove ${OBJDUMP} as it is not used by the base system (authored by emaste). · Explain WhyJul 27 2016, 2:58 PM

This revision was automatically updated to reflect the committed changes.

In D6460#152565, @emaste wrote:

In D6460#136996, @brooks wrote:

Yeah, we have a WANT_DUMP make file option to that runs ${OBJDUMP} -xrsSD on programs (and shortly shared libraries) to help understand instruction traces.

Ok, my proposal: I commit this for now, you can carry the revert in CheriBSD, and we'll subsequently see about improving non-binutils tools (e.g. LLVM objdump) or finding a clean way to use an external toolchain objdump.