Page MenuHomeFreeBSD

Remove ${OBJDUMP} make variable as it is not used by the base system
ClosedPublic

Authored by emaste on May 19 2016, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 8:47 PM
Unknown Object (File)
Mar 19 2024, 11:00 AM
Unknown Object (File)
Feb 14 2024, 4:33 AM
Unknown Object (File)
Jan 8 2024, 9:34 PM
Unknown Object (File)
Jan 8 2024, 9:34 PM
Unknown Object (File)
Jan 8 2024, 9:34 PM
Unknown Object (File)
Jan 8 2024, 9:17 PM
Unknown Object (File)
Dec 22 2023, 9:27 PM
Subscribers
None

Details

Summary

It was added to sys.mk relatively recently in rS274503 for EFI builds but is no longer used in the base system

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to Remove ${OBJDUMP} make variable as it is not used by the base system.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: bdrewery, andrew, smh.
bdrewery edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 7:27 PM

I don't object, but we use it in CheriBSD so I'll have to revert this change there.

I don't object, but we use it in CheriBSD so I'll have to revert this change there.

Ah, we should be able to get the equivalent of the -x, -r, and -s options from readelf, but not -S or -D which are probably the most interesting :(

I don't object, but we use it in CheriBSD so I'll have to revert this change there.

Ah, we should be able to get the equivalent of the -x, -r, and -s options from readelf, but not -S or -D which are probably the most interesting :(

Yeah, we have a WANT_DUMP make file option to that runs ${OBJDUMP} -xrsSD on programs (and shortly shared libraries) to help understand instruction traces.

Yeah, we have a WANT_DUMP make file option to that runs ${OBJDUMP} -xrsSD on programs (and shortly shared libraries) to help understand instruction traces.

Ok, my proposal: I commit this for now, you can carry the revert in CheriBSD, and we'll subsequently see about improving non-binutils tools (e.g. LLVM objdump) or finding a clean way to use an external toolchain objdump.

This revision was automatically updated to reflect the committed changes.

Yeah, we have a WANT_DUMP make file option to that runs ${OBJDUMP} -xrsSD on programs (and shortly shared libraries) to help understand instruction traces.

Ok, my proposal: I commit this for now, you can carry the revert in CheriBSD, and we'll subsequently see about improving non-binutils tools (e.g. LLVM objdump) or finding a clean way to use an external toolchain objdump.

That's fine.