Paths

Table of Contentst

sound: Retire feeder_class->desc
ClosedPublic
Actions

Authored by christos on Nov 3 2025, 3:31 PM.

Details

Reviewers

markj
emaste

Commits

rGae3cd550d257: sound: Retire feeder_class->desc
rG91fcc0132d0b: sound: Retire feeder_class->desc

Summary

The only field we care about is pcm_feederdesc->type, so keep that one
only and do not embed the whole pcm_feederdesc.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68380
Build 65263: arc lint + arc unit

Event Timeline

christos created this revision.Nov 3 2025, 3:31 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 3 2025, 3:31 PM

christos requested review of this revision.Nov 3 2025, 3:31 PM

Harbormaster completed remote builds in B68380: Diff 165740.Nov 3 2025, 3:31 PM

christos added a parent revision: D53555: sound: Retire feeder_class->data.Nov 3 2025, 3:31 PM

christos added a child revision: D53557: sound: Retire pcm_feederdesc->type.

markj accepted this revision.Nov 4 2025, 12:51 PM

This revision is now accepted and ready to land.Nov 4 2025, 12:51 PM

markj added inline comments.Nov 4 2025, 12:52 PM

sys/dev/sound/pcm/feeder.h
76	Is there any reason not to give this type a name, so you can use it for the `type` field above in struct feeder_class?

christos marked an inline comment as done.Nov 6 2025, 2:07 PM

Closed by commit rG91fcc0132d0b: sound: Retire feeder_class->desc (authored by christos). · Explain WhyNov 11 2025, 12:08 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG91fcc0132d0b: sound: Retire feeder_class->desc.

christos added a commit: rGae3cd550d257: sound: Retire feeder_class->desc.Nov 18 2025, 12:52 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

feeder.h

6 lines

feeder.c

8 lines

Diff 165740

View Options

sys/dev/sound/pcm/feeder.h