sound: Retire unused sndbuf_getflags() and sndbuf_setflags()
ClosedPublic
Actions

Authored by christos on Nov 1 2025, 10:50 PM.

Details

Reviewers

markj
emaste

Commits

rG418c7be1760d: sound: Retire unused sndbuf_getflags() and sndbuf_setflags()
rG06eb65e11d7a: sound: Retire unused sndbuf_getflags() and sndbuf_setflags()

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68368
Build 65251: arc lint + arc unit

Event Timeline

christos created this revision.Nov 1 2025, 10:50 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2025, 10:50 PM

christos requested review of this revision.Nov 1 2025, 10:50 PM

Harbormaster completed remote builds in B68339: Diff 165652.Nov 1 2025, 10:50 PM

christos added a child revision: D53526: sound: Simplify sndbuf_clear() loop.Nov 1 2025, 10:50 PM

Why is the change adding a copyright? The rest of the diff is just removing code. If the copyright is intended to reflect previous additions to the files, it should be added separately.

In D53525#1222253, @markj wrote:

Why is the change adding a copyright? The rest of the diff is just removing code. If the copyright is intended to reflect previous additions to the files, it should be added separately.

I added these because IIRC (could be wrong) if 10/20%+ of the file has been modified, which is the case now after these recent patches.

Remove copyright and add it in separate commit.

Harbormaster completed remote builds in B68368: Diff 165719.Nov 3 2025, 12:01 PM

markj accepted this revision.Nov 3 2025, 1:46 PM

This revision is now accepted and ready to land.Nov 3 2025, 1:46 PM

Closed by commit rG06eb65e11d7a: sound: Retire unused sndbuf_getflags() and sndbuf_setflags() (authored by christos). · Explain WhyNov 11 2025, 12:08 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG06eb65e11d7a: sound: Retire unused sndbuf_getflags() and sndbuf_setflags().

christos added a commit: rG418c7be1760d: sound: Retire unused sndbuf_getflags() and sndbuf_setflags().Nov 18 2025, 12:52 AM