Page MenuHomeFreeBSD
Differential D53526

sound: Simplify sndbuf_clear() loop
ClosedPublic
Actions

Authored by christos on Nov 1 2025, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 16, 3:44 PM
Unknown Object (File)
Fri, Sep 11, 7:24 AM
Unknown Object (File)
Fri, Sep 11, 6:37 AM
Unknown Object (File)
Thu, Sep 10, 10:27 AM
Unknown Object (File)
Mon, Sep 7, 5:28 PM
Unknown Object (File)
Sun, Sep 6, 2:39 AM
Unknown Object (File)
Sat, Sep 5, 11:26 PM
Unknown Object (File)
Sat, Sep 5, 11:18 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGd5024179b8dd: sound: Simplify sndbuf_clear() loop
rGc0e96595a4da: sound: Simplify sndbuf_clear() loop
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Nov 1 2025, 10:50 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 1 2025, 10:50 PM
christos requested review of this revision.Nov 1 2025, 10:50 PM
Harbormaster completed remote builds in B68340: Diff 165653.Nov 1 2025, 10:50 PM
christos added a parent revision: D53525: sound: Retire unused sndbuf_getflags() and sndbuf_setflags().Nov 1 2025, 10:50 PM
christos added a child revision: D53527: sound: Remove redundant sndbuf_free() in chn_kill().
markj added inline comments.Nov 2 2025, 4:19 PM
sys/dev/sound/pcm/buffer.c
281–282
for (; length > 0; length--, i++)
    p[i % b->bufsize] = data;
christos updated this revision to Diff 165717.Nov 3 2025, 11:58 AM
christos marked an inline comment as done.

Address Mark's comment.

Harbormaster completed remote builds in B68367: Diff 165717.Nov 3 2025, 11:58 AM
markj accepted this revision.Nov 3 2025, 1:47 PM
This revision is now accepted and ready to land.Nov 3 2025, 1:47 PM
Closed by commit rGc0e96595a4da: sound: Simplify sndbuf_clear() loop (authored by christos). · Explain WhyNov 11 2025, 12:08 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGc0e96595a4da: sound: Simplify sndbuf_clear() loop.
christos added a commit: rGd5024179b8dd: sound: Simplify sndbuf_clear() loop.Nov 18 2025, 12:52 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
10 lines

Diff 166209

View Options

sys/dev/sound/pcm/buffer.c

Loading...