sound: Remove redundant sndbuf_free() in chn_kill()
Needs ReviewPublic
Actions

Authored by christos on Sat, Nov 1, 10:50 PM.

Tags

None

Referenced Files

	F134953286: D53527.id165654.diff
	Wed, Nov 5, 10:11 AM

	Unknown Object (File)
	Tue, Nov 4, 4:22 PM

	Unknown Object (File)
	Sun, Nov 2, 4:47 PM

	Unknown Object (File)
	Sun, Nov 2, 4:47 PM

	Unknown Object (File)
	Sun, Nov 2, 12:19 PM

	Unknown Object (File)
	Sun, Nov 2, 5:42 AM

	Unknown Object (File)
	Sun, Nov 2, 5:39 AM

	Unknown Object (File)
	Sun, Nov 2, 3:41 AM

View All 11 Files

Subscribers

imp

Details

Reviewers

markj
emaste

Summary

If b exists, it will get destroyed by sndbuf_destroy() (which calls
sndbuf_free()) a few lines below, so the additional sndbuf_free() here
is redundant.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68341
Build 65224: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Nov 1, 10:50 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 1, 10:50 PM

christos requested review of this revision.Sat, Nov 1, 10:50 PM

Harbormaster completed remote builds in B68341: Diff 165654.Sat, Nov 1, 10:50 PM

christos added a parent revision: D53526: sound: Simplify sndbuf_clear() loop.Sat, Nov 1, 10:50 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

4 lines

Diff 165654

View Options

sys/dev/sound/pcm/channel.c

sound: Remove redundant sndbuf_free() in chn_kill()Needs ReviewPublicActions