sound: Remove redundant sndbuf_free() in chn_kill()
ClosedPublic
Actions

Authored by christos on Nov 1 2025, 10:50 PM.

Details

Reviewers

markj
emaste

Commits

rG7ed840e33127: sound: Remove redundant sndbuf_free() in chn_kill()
rGad28c6a13a45: sound: Remove redundant sndbuf_free() in chn_kill()

Summary

If b exists, it will get destroyed by sndbuf_destroy() (which calls
sndbuf_free()) a few lines below, so the additional sndbuf_free() here
is redundant.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Nov 1 2025, 10:50 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2025, 10:50 PM

christos requested review of this revision.Nov 1 2025, 10:50 PM

Harbormaster completed remote builds in B68341: Diff 165654.Nov 1 2025, 10:50 PM

christos added a parent revision: D53526: sound: Simplify sndbuf_clear() loop.Nov 1 2025, 10:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2025, 12:08 PM

Closed by commit rGad28c6a13a45: sound: Remove redundant sndbuf_free() in chn_kill() (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGad28c6a13a45: sound: Remove redundant sndbuf_free() in chn_kill().

christos added a commit: rG7ed840e33127: sound: Remove redundant sndbuf_free() in chn_kill().Nov 18 2025, 12:52 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

4 lines

Diff 166210

View Options

sys/dev/sound/pcm/channel.c

sound: Remove redundant sndbuf_free() in chn_kill()ClosedPublicActions