Page MenuHomeFreeBSD

d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
ClosedPublic

Authored by 0mp on Oct 28 2025, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 23, 6:18 AM
Unknown Object (File)
Thu, May 21, 3:41 PM
Unknown Object (File)
Wed, May 20, 10:38 PM
Unknown Object (File)
Wed, May 20, 3:05 PM
Unknown Object (File)
Wed, May 20, 3:02 PM
Unknown Object (File)
Wed, May 20, 12:10 PM
Unknown Object (File)
Wed, May 20, 11:31 AM
Unknown Object (File)
Tue, May 19, 8:41 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68306
Build 65189: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Oct 28 2025, 8:20 PM
markj added inline comments.
share/man/man7/d.7
208

What is returned if there is no match? NULL, or the empty string?

217

I don't think the comparison to strcat is useful. (Really, the comparisons to C functions in general isn't useful IMO: if you know C, then these functions are familiar, and if you don't the comparisons mean nothing.)

  • Add examples
  • Do not refer to C functions
  • Explain return values
0mp marked 2 inline comments as done.Oct 31 2025, 2:01 PM
0mp added inline comments.
share/man/man7/d.7
208

I've added those details.

217

Good point. Thanks! I removed those pointers.

0mp marked 2 inline comments as done.Oct 31 2025, 2:01 PM
This revision is now accepted and ready to land.Nov 2 2025, 5:09 PM