pkg: Die if make -V BRANCH fails
ClosedPublic
Actions

Authored by cperciva on Oct 30 2025, 8:47 PM.

Details

Reviewers

ivy
bdrewery
sjg

Commits

rG65a3f9cf305d: pkg: Die if make -V BRANCH fails
rG1f528e32f509: pkg: Die if make -V BRANCH fails
rG0837b2ebd570: pkg: Die if make -V BRANCH fails

Summary

If build logic breaks such that we can't figure out which branch we're
on, we should error out rather than shipping a default (and probably
wrong) /etc/pkg/FreeBSD.conf

MFC after: 5 minutes
Suggested by: ivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68297
Build 65180: arc lint + arc unit

Event Timeline

cperciva created this revision.Oct 30 2025, 8:47 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptOct 30 2025, 8:47 PM

Herald added a subscriber: imp. · View Herald Transcript

cperciva requested review of this revision.Oct 30 2025, 8:47 PM

Harbormaster completed remote builds in B68297: Diff 165493.Oct 30 2025, 8:47 PM

cperciva mentioned this in D53486: release: Only check no-root/no-qemu when building.Oct 30 2025, 8:47 PM

ivy accepted this revision.Oct 30 2025, 8:49 PM

ivy added a reviewer: sjg.

This revision is now accepted and ready to land.Oct 30 2025, 8:49 PM

Closed by commit rG0837b2ebd570: pkg: Die if make -V BRANCH fails (authored by cperciva). · Explain WhyOct 30 2025, 8:51 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG0837b2ebd570: pkg: Die if make -V BRANCH fails.

cperciva added a commit: rG1f528e32f509: pkg: Die if make -V BRANCH fails.

cperciva added a commit: rG65a3f9cf305d: pkg: Die if make -V BRANCH fails.Oct 30 2025, 8:54 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pkg/

Makefile

1 line

Diff 165493

View Options

pkg: Die if make -V BRANCH failsClosedPublicActions