Page MenuHomeFreeBSD

d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
ClosedPublic

Authored by 0mp on Oct 28 2025, 8:20 PM.
Tags
None
Referenced Files
F169999303: D53417.id165571.diff
Thu, Sep 3, 5:32 AM
Unknown Object (File)
Wed, Sep 2, 8:42 PM
Unknown Object (File)
Wed, Sep 2, 3:04 PM
Unknown Object (File)
Wed, Sep 2, 2:10 PM
Unknown Object (File)
Tue, Sep 1, 5:08 AM
Unknown Object (File)
Tue, Sep 1, 5:03 AM
Unknown Object (File)
Mon, Aug 31, 7:28 PM
Unknown Object (File)
Mon, Aug 31, 3:06 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68191
Build 65074: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Oct 28 2025, 8:20 PM
markj added inline comments.
share/man/man7/d.7
208

What is returned if there is no match? NULL, or the empty string?

217

I don't think the comparison to strcat is useful. (Really, the comparisons to C functions in general isn't useful IMO: if you know C, then these functions are familiar, and if you don't the comparisons mean nothing.)

  • Add examples
  • Do not refer to C functions
  • Explain return values
0mp marked 2 inline comments as done.Oct 31 2025, 2:01 PM
0mp added inline comments.
share/man/man7/d.7
208

I've added those details.

217

Good point. Thanks! I removed those pointers.

0mp marked 2 inline comments as done.Oct 31 2025, 2:01 PM
This revision is now accepted and ready to land.Nov 2 2025, 5:09 PM