Page MenuHomeFreeBSD
Differential D53064

mandoc: Also run makewhatis for /usr/share/openssl/man
ClosedPublic
Actions

Authored by ivy on Oct 13 2025, 12:45 PM.
Tags
None
Referenced Files
F163533325: D53064.id164377.diff
Fri, Jul 24, 5:26 AM
Unknown Object (File)
Thu, Jul 23, 1:16 AM
Unknown Object (File)
Tue, Jul 21, 1:35 AM
Unknown Object (File)
Tue, Jul 21, 12:48 AM
Unknown Object (File)
Mon, Jul 20, 4:29 PM
Unknown Object (File)
Mon, Jul 20, 3:23 PM
Unknown Object (File)
Sun, Jul 19, 8:11 PM
Unknown Object (File)
Sun, Jul 19, 12:41 PM
View All 95 Files
Subscribers
emaste
imp

Details

Reviewers
bapt
ziaee
emaste
Group Reviewers
pkgbase
Commits
rG873f0864dbf2: mandoc: Also run makewhatis for /usr/share/openssl/man
rG37effd917ed8: mandoc: Also run makewhatis for /usr/share/openssl/man
rG450fb637f453: mandoc: Also run makewhatis for /usr/share/openssl/man
Summary

We use a pkg(8) trigger to run makewhatis for /usr/share/man when
manpages are updated, but this doesn't cover /usr/share/openssl/man.

Rewrite the trigger to process a list of directories instead of a
single directory, and include /usr/share/openssl/man in the list.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Oct 13 2025, 12:45 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2025, 12:45 PM
ivy requested review of this revision.Oct 13 2025, 12:45 PM
Harbormaster completed remote builds in B67747: Diff 164086.Oct 13 2025, 12:45 PM
emaste added a subscriber: emaste.Oct 15 2025, 5:42 PM

This seems reasonable to me

emaste accepted this revision as: emaste.Oct 15 2025, 6:43 PM

OK.

Two things feel a bit odd to me ([ -d DIR ] could be done directly in lua I think, and the DIR gsub rather than just using dir inline a few times) but it should function fine.

This revision is now accepted and ready to land.Oct 15 2025, 6:43 PM
ivy added a comment.Oct 15 2025, 6:51 PM
In D53064#1213503, @emaste wrote:

Two things feel a bit odd to me ([ -d DIR ] could be done directly in lua I think

i am not sure there is a way to check if a directory (or a file) exists in Lua. is there?

ivy updated this revision to Diff 164377.Oct 17 2025, 7:28 AM

use pkg.stat to check for directory existence

also, remove /usr/share/openssl/man/mandoc.db on removal.

This revision now requires review to proceed.Oct 17 2025, 7:28 AM
Harbormaster completed remote builds in B67853: Diff 164377.Oct 17 2025, 7:28 AM
emaste accepted this revision as: emaste.Oct 17 2025, 1:41 PM
This revision is now accepted and ready to land.Oct 17 2025, 1:41 PM
Closed by commit rG450fb637f453: mandoc: Also run makewhatis for /usr/share/openssl/man (authored by ivy). · Explain WhyOct 26 2025, 2:28 AM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG450fb637f453: mandoc: Also run makewhatis for /usr/share/openssl/man.
ivy added a commit: rG37effd917ed8: mandoc: Also run makewhatis for /usr/share/openssl/man.Oct 30 2025, 12:35 PM
cperciva added a commit: rG873f0864dbf2: mandoc: Also run makewhatis for /usr/share/openssl/man.Oct 30 2025, 4:15 PM

Revision Contents
Changeset List

PathSize
usr.bin/
mandoc/
20 lines

Diff 165046

View Options

usr.bin/mandoc/mandoc.ucl

Loading...